fix: emit matching close tag for inner shadow effect - #3
Merged
Conversation
Adopts upstream PR gitbrent#1455. An inner shadow opened <a:innerShdw> but the closing tag was hard-coded to </a:outerShdw>, producing mismatched XML that corrupts the PPTX. Close with the same shadow type that was opened. Original work by @dxsun97 in gitbrent#1455 (MIT). Co-Authored-By: dxsun97 <sun183509@qq.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
MBuelowius
force-pushed
the
fix/inner-shadow-1455
branch
from
June 23, 2026 13:44
7848cee to
c642152
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original author: @dxsun97 — adopted from upstream gitbrent/PptxGenJS#1455 (MIT). Credited via
Co-Authored-Bytrailer.An inner shadow opened
<a:innerShdw>but the close tag was hard-coded to</a:outerShdw>, producing mismatched XML that corrupts the PPTX. Now closes with the same shadow type that was opened.tsc --noEmitclean.dist/not rebuilt here.