CSV Improvements: RVI/MVI and Units by jasondegraw · Pull Request #9395 · NatLabRockies/EnergyPlus

jasondegraw · 2022-04-22T18:57:53Z

Pull request overview

The current native CSV output is much faster than but not as flexible as the outputs that can be produced by the ReadVars post-processing workflow. Unit options are limited and there is no analog of the RVI/MVI file. Develop a replacement for RVI/MVI input that allows the user to select units, ordering of outputs, and other reporting options that will allow ReadVars users to transition to the built-in CSV workflow.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

rraustad · 2022-04-22T19:56:19Z

+## References ##
+
+---
+


This looks perfectly reasonable. I was thinking if the csv is not created/requested and these new objects are present in the input then the "unused objects" message will show up in the err file, and if the csv is created/requested those messages will not show up.

OutputControl:Files, No, !- Output CSV

JasonGlazer · 2022-04-25T15:51:40Z

Overall this is a great change.

a) Perhaps the input object names "OutputControl:RVI" and "OutputControl:MVI" should be more descriptive such as "OutputControl:CSV:SelectedOutputVariableOrder" and "OutputControl:CSV:SelectedMeterOrder" or something.

b) I believe that even if the RVI or MVI had a column that was not an existing variable that it would leave a blank column for that variable (someone else maybe can confirm this) so that the spreadsheet that is created had a fixed set of columns. Is this still going to occur?

c) Are there any other features of ReadVARSESO that are not supported? If so, please identify them.

d) ConvertESOMTR had this unique conversion to IP approach that worked with the names of the output variables. If it was output in Joules and the name contained the string "elec" it was converted to kWh, if it contained the string "gas" it was converted to therms, if it contained "cool" it was converted to ton-hr. Similarly, the output was Watts and the name contained "elec" then it was converted to kW. This is better than just converting all JtokWH as an option. I suggest that you add "JtoAuto" option in "OutputControl:CSV:Style" to replicate this.

e) Related to the last item, ConvertESOMTR used a "convert.txt" file to specify the rules of conversions which would allow users to modify the rules. I presume we are losing this capability. I don't think this is a big deal since I think it rarely (or maybe never) happened, but I just want to double-check that the "convert.txt" file is not going to be used anymore.

f) There is a little-used program called CSVproc that creates some simple statistics for each column in the CSV file. It would be great if this could just be done as part of this work (it is just the sum, max, min, average plus some counts) and this could be an added option to "OutputControl:CSV:Style" like "Generate simple statistics" maybe these are added to the bottom of the CSV file? It would be nice to eliminate this little program as well.

g) Are we going to eliminate ReadVARSESO and ConvertESOMTR from the installer? If so this may necessitate other changes to EP-Launch 2 source code and EP-Launch 3 workflows. Post an issue pointing to me about this if that is what is decided.

h) One other suggestion, Excel locks the CSV file so that it cannot be written to but it is very common for users to try to run EnergyPlus with the CSV opened by accident. EP-Launch detects this and shows a warning but maybe EnergyPlus should also do something initially when processing the command line options (maybe it does already) and just put a message up and not bother with the simulation.

mjwitte · 2022-04-25T20:39:46Z

If you want to be feature-complete with ReadVarsESO, there is also an option to filter output variables by reporting frequency. e.g. ReadVarsESO.exe my.rvi timestep will pass through only selected variables which have been requested at the timestep reporting frequency. ExerciseOutput1-CustomCSV.bat is an example that calls ReadVarsESO multiple times to create a separate csv output for each reporting frequency. One way to support this might be additional fields in the proposed OutputControl:CSV:Style object:

 A2, \field Output Variable Reporting Frequency
       \type choice
       \key AllCombined - default, all reporting frequencies combined in the same csv output file
       \key AllSeparated - each reporting frequency sent to a separate csv output file, e.g. eplusout_hourly.csv
       \key Hourly - only variables with hourly reporting frequency will be included in the csv output file
       \key Daily
       \key Monthly
       \key RunPeriod
       \key Environment
       \key Annual
       \default AllCombined 
 A3; \field Meter Variable Reporting Frequency

mjwitte · 2022-04-25T20:59:50Z

Regarding item b) above, ReadVarsESO does not leave blank columns if a variable is name in the rvi is not present in the idf Output:Variable or Output:Meter objects.

Also, in case you don't realize this, ReadVarsESO matches initial substrings in the variable name. For example "Zone Air" in the rvi will match all occurrences of Zone Air Temperature, Zone Air System Sensible Cooling Rate, etc. Not sure if it's important to support this, but noting it's a feature.

JasonGlazer · 2022-04-26T12:12:43Z

Regarding item b) above, ReadVarsESO does not leave blank columns if a variable is name in the rvi is not present in the idf Output:Variable or Output:Meter objects.

Thanks for clarifying that.

jasondegraw · 2022-05-04T15:24:31Z

@JasonGlazer thanks for the feedback! Here are responses to most of your comments, we'll drop b) because @mjwitte has responded on that.

a) Perhaps the input object names "OutputControl:RVI" and "OutputControl:MVI" should be more descriptive such as "OutputControl:CSV:SelectedOutputVariableOrder" and "OutputControl:CSV:SelectedMeterOrder" or something.

We're fine with the names you're proposing, it makes sense to drop the "RVI" and "MVI" terminology.

c) Are there any other features of ReadVARSESO that are not supported? If so, please identify them.

As far as we know, the things missing are mentioned in Mike's comment:

String matching
Frequency filtering

d) ConvertESOMTR had this unique conversion to IP approach that worked with the names of the output variables. If it was output in Joules and the name contained the string "elec" it was converted to kWh, if it contained the string "gas" it was converted to therms, if it contained "cool" it was converted to ton-hr. Similarly, the output was Watts and the name contained "elec" then it was converted to kW. This is better than just converting all JtokWH as an option. I suggest that you add "JtoAuto" option in "OutputControl:CSV:Style" to replicate this.

We are not terribly opposed to including this, but we are concerned that this will push our budget/time limits. If it isn’t a “must have”, then perhaps it could be a stretch goal? If this is a “must have”, we could combine it with e) as a FY23 new feature to guarantee it gets done.

e) Related to the last item, ConvertESOMTR used a "convert.txt" file to specify the rules of conversions which would allow users to modify the rules. I presume we are losing this capability. I don't think this is a big deal since I think it rarely (or maybe never) happened, but I just want to double-check that the "convert.txt" file is not going to be used anymore.

This is probably a bit out of our original scope, but we would not envision using a separate file if we did implement it. A potential solution would be to combine it with d) above for FY23.

f) There is a little-used program called CSVproc that creates some simple statistics for each column in the CSV file. It would be great if this could just be done as part of this work (it is just the sum, max, min, average plus some counts) and this could be an added option to "OutputControl:CSV:Style" like "Generate simple statistics" maybe these are added to the bottom of the CSV file? It would be nice to eliminate this little program as well.

We are reluctant to include additional “special” rows (beyond headers) based upon (very emphatic) user feedback. This seems like something that would still be best done as a postprocessing step (which would mean keeping CSVProc, but the program could be translated to Python).

g) Are we going to eliminate ReadVARSESO and ConvertESOMTR from the installer? If so this may necessitate other changes to EP-Launch 2 source code and EP-Launch 3 workflows. Post an issue pointing to me about this if that is what is decided.

We do believe that these programs should be deprecated at some point, but not in this PR. We would like to consider redirecting the --readvars command line option to use this new feature as part of this PR. We're not sure how that would impact EP-Launch, so there definitely needs to be discussion.

h) One other suggestion, Excel locks the CSV file so that it cannot be written to but it is very common for users to try to run EnergyPlus with the CSV opened by accident. EP-Launch detects this and shows a warning but maybe EnergyPlus should also do something initially when processing the command line options (maybe it does already) and just put a message up and not bother with the simulation.

E+ will probably detect that there’s something going on when it can’t open the file for writing, but we’ll have to look into what it does then. We think that handling it as a “failure to open output file” error is probably the way to go, other options may get platform specific really quickly.

jasondegraw · 2022-05-04T15:39:16Z

@mjwitte thanks for the comments and feedback!

If you want to be feature-complete with ReadVarsESO, there is also an option to filter output variables by reporting frequency. e.g. ReadVarsESO.exe my.rvi timestep will pass through only selected variables which have been requested at the timestep reporting frequency. ExerciseOutput1-CustomCSV.bat is an example that calls ReadVarsESO multiple times to create a separate csv output for each reporting frequency. One way to support this might be additional fields in the proposed OutputControl:CSV:Style object:

We were aware of this capability, and we had looked into a little, but hadn't decided whether we should implement it or not. We'll take a harder look, and if it is feasible we'll do something. I don't know if that would necessarily mean multiple files or not, we'll just have to see how it plays out.

Also, in case you don't realize this, ReadVarsESO matches initial substrings in the variable name. For example "Zone Air" in the rvi will match all occurrences of Zone Air Temperature, Zone Air System Sensible Cooling Rate, etc. Not sure if it's important to support this, but noting it's a feature.

We had missed this in the review of ReadVars, thanks for catching this. This can probably be handled using the code that does matching for the output variables themselves, and if that can be done then this should be (relatively) easy to do. We’ll look into it and if it is feasible, we’ll do it.

nrel-bot · 2022-06-02T00:26:02Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-3 · 2022-06-30T00:21:44Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2022-07-28T00:42:07Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

Myoldmopar · 2022-07-29T21:25:54Z

@jasondegraw do you anticipate this progressing for I/O freeze? I'm just scanning PRs looking at milestones now while prepping for the review push over the next couple weeks. Thanks! (If I repeat this comment on any other PRs, my apologies for cross posting.)

nrel-bot-3 · 2022-08-30T03:00:42Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2 · 2022-09-27T00:16:45Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

…tput

nrel-bot · 2022-10-28T00:17:57Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2 · 2022-11-25T00:20:50Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2022-12-23T00:21:07Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2023-01-20T00:28:49Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

Myoldmopar · 2023-02-09T15:38:51Z

@jasondegraw I saw you made a commit here. Are you planning on pushing on this in the very near term to get this into the 23.1 IO freeze next week?

jasondegraw · 2023-02-09T20:57:49Z

@Myoldmopar Yes, working on it right now.

nrel-bot-2c · 2026-06-25T00:29:16Z