[mitchute]

Pull request overview

• Update Zone Air Heat Balance Deviation Rate Docs for ThirdOrderBackwardDifference #11842 pointed out that there's a mismatch for third-order backward difference zone air heat-balance storage reporting. This corrects the difference.

Description of the purpose of this PR

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
• If adding/removing any output files (e.g., eplustbl.*)
  • Update ..\scripts\Epl-run.bat
  • Update ..\scripts\RunEPlus.bat
  • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
  • Update ...github\workflows\energyplus.py

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[mitchute]

@RKStrand is this in your wheelhouse?

[mitchute]

Minor diffs consistent with the plots below are expected.

[github-actions]

⚠️ Regressions detected on macos-15 for commit 57fc5c9

Regression Summary

• ESO Small Diffs: 3
• ESO Big Diffs: 16
• ERR: 1

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on ubuntu-24.04 for commit 57fc5c9

Regression Summary

• ESO Small Diffs: 3
• ESO Big Diffs: 16
• ERR: 1

• View Results
• Download Regressions

[RKStrand]

I can try to take a look at that tomorrow. I didn't implement this in EnergyPlus, but I know what the code is and what it's supposed to be doing. So, yes, it's probably in my "wheelhouse".

[RKStrand]

@mitchute Ok, I see what is going on here and why this reporting was off. Based on the code change, this looks like the correct solution to me.

[mitchute]

Thanks for reviewing @RKStrand.