-
Notifications
You must be signed in to change notification settings - Fork 3
Ar migrate storage builds drafts #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
388aa4c
Comment out bytes test for now
alexrichey 40d5791
Update sample .env
alexrichey 2c669ec
Add pub root folder to config
alexrichey b1ae54f
DANGER ZONE! remove rmtree from hps
alexrichey ebf3161
Configure the connectors in lifecycle builds
alexrichey 3fe4439
Add builds conn
alexrichey 3815ca2
Add drafts conn
alexrichey 296a88f
Add published conn
alexrichey 59cdffa
Add GIS conn
alexrichey 4e8b20e
Add new connectors to the registry
alexrichey 74bd2a0
Add a CLI in lifecycle
alexrichey 8258bb3
Add e2e test
alexrichey 70ed00f
post-review: remove slop-comments
alexrichey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| BUILD_ENGINE=postgresql://postgres:postgres@localhost:5432/postgres | ||
| AWS_S3_ENDPOINT= | ||
| AWS_S3_ENDPOINT=https://nyc3.digitaloceanspaces.com | ||
| AWS_SECRET_ACCESS_KEY= | ||
| AWS_ACCESS_KEY_ID= | ||
| RECIPES_BUCKET= | ||
| RECIPE_ENGINE= | ||
| RECIPES_BUCKET=edm-recipes | ||
| RECIPE_ENGINE= | ||
| PUBLISHING_BUCKET=edm-publishing | ||
| PUBLISHING_BUCKET_ROOT_FOLDER= | ||
| PRODUCT_METADATA_REPO_PATH=../product-metadata/ | ||
| TEMPLATE_DIR=./ingest_templates |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omg. I'm sure I'm guilty of this too somewhere