Repository navigation
Fix op_dag subtraction operators evaluating as addition - #147
Merged
ajaypanyala merged 2 commits intoSep 23, 2026
Merged
Conversation
The operator- overloads building op trees had the same body as operator+, so the right-hand operand was never negated. Negate it: rhs becomes -1.0 * rhs and a scalar value becomes -value. Fixes NWChemEx#146 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
|
ajaypanyala
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146
Problem
The
operator-overloads insrc/tamm/op_dag.hppthat build op trees had the same body as the matchingoperator+overloads. The right-hand operand was never negated, soA - Bbuilt the sameAddOpasA + B.Change
Negate the right-hand operand in each of the three subtraction overloads:
lhs - rhs->{lhs, -1.0 * rhs}lhs - value->{lhs, Scalar{-value}}value - rhs->{Scalar{value}, -1.0 * rhs}Testing
Not built or tested locally. This PR adds no regression test.
🤖 Generated with Claude Code