Skip to content

Cleanup cutile-compiler#47

Open
ur4t wants to merge 9 commits into
NVlabs:mainfrom
ur4t:cleanup-cutile-compiler
Open

Cleanup cutile-compiler#47
ur4t wants to merge 9 commits into
NVlabs:mainfrom
ur4t:cleanup-cutile-compiler

Conversation

@ur4t
Copy link
Copy Markdown
Contributor

@ur4t ur4t commented Mar 26, 2026

No description provided.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ur4t ur4t mentioned this pull request Mar 26, 2026
@ur4t ur4t force-pushed the cleanup-cutile-compiler branch from a9350d6 to 984dfd9 Compare April 3, 2026 02:53
@ur4t ur4t force-pushed the cleanup-cutile-compiler branch from 984dfd9 to 51a397a Compare April 10, 2026 03:14
@elibol
Copy link
Copy Markdown
Collaborator

elibol commented Apr 11, 2026

Thanks for the cleanup! Since this touches compiler internals (_function.rs, _type.rs, _value.rs, bounds.rs), I want to look at it more closely. We also have a compiler rewrite in progress that will likely make these changes obsolete. It might make sense to wait until that lands and then take a pass on the updated compiler (if you're interested). Will follow up.

@ur4t
Copy link
Copy Markdown
Contributor Author

ur4t commented Apr 11, 2026

We also have a compiler rewrite in progress that will likely make these changes obsolete. It might make sense to wait until that lands and then take a pass on the updated compiler.

Sure. I will rebase when it lands.

@ur4t ur4t force-pushed the cleanup-cutile-compiler branch 2 times, most recently from e98e6a3 to 21915cd Compare April 16, 2026 03:27
@ur4t
Copy link
Copy Markdown
Contributor Author

ur4t commented Apr 17, 2026

I investigated functions marked #[allow(clippy::too_many_arguments)]. Some of them, especially fhmas, require those arguments natively. The others are about compile, from which we can indeed extract shared arguments into an argument "bundle".

I thought #[allow(clippy::too_many_arguments)] might be conspicuous enough so I did not add // TODO.

@ur4t ur4t force-pushed the cleanup-cutile-compiler branch from 21915cd to dc8dcd1 Compare April 22, 2026 02:54
@jollylili jollylili added the P2 label Apr 24, 2026
@ur4t ur4t force-pushed the cleanup-cutile-compiler branch 3 times, most recently from 00e53b9 to 03e3170 Compare April 30, 2026 03:26
@ur4t ur4t force-pushed the cleanup-cutile-compiler branch from 03e3170 to 9b10af1 Compare May 6, 2026 02:19
@ur4t ur4t force-pushed the cleanup-cutile-compiler branch from 9b10af1 to 44e6614 Compare May 9, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants