-
Notifications
You must be signed in to change notification settings - Fork 107
Feat: Unified Scene Data Flow #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WCJ-BERT
wants to merge
17
commits into
NVlabs:main
Choose a base branch
from
WCJ-BERT:adapt_to_new_runtime
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8b80512
feat: add SceneDataSource protocol and DataSourceConfig
WCJ-BERT d2bf456
feat: implement TrajdataDataSource for direct trajdata loading
WCJ-BERT 1a49654
refactor!: migrate RuntimeContext to use scene_id_to_idx mapping
WCJ-BERT bcfaaa3
feat: update DaemonEngine to support lazy scene loading
WCJ-BERT 1cb807a
feat: add prepare_data CLI for trajdata cache preprocessing
WCJ-BERT 1ded645
feat: integrate SceneDataSource into worker and simulation flow
WCJ-BERT aade78b
refactor: improve coordinate frame variable naming
WCJ-BERT e487b14
test: update tests for trajdata data source migration
WCJ-BERT 486d87d
docs(wizard): add trajdata documentation and wizard config
WCJ-BERT 848d89e
fix: update copyright year to 2026 for new files
WCJ-BERT eff4513
refactor: improve configuration structure and validation
WCJ-BERT b773aff
refactor: simplify and clean up codebase
WCJ-BERT 8cd4958
refactor: add UnifiedDataset to RuntimeContext to avoid duplication
WCJ-BERT 6791e1b
refactor: encapsulate scene loading into SceneLoader class
WCJ-BERT 74399c9
refactor: improve prepare_data code quality and unify preprocessing
WCJ-BERT 74e7d18
refactor: address PR review feedback for trajdata_data_source
WCJ-BERT 3dbe2c8
fix: align data_source config structure between YAML and DataSourceCo…
WCJ-BERT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not catching this earlier. One concern I have is that we can have two artifacts with the same clip id (which is I think how the caching is done) but with different versions. The way that we get around this in the existing approach is to have a UUID for the usdz filename and an a scene database (really a csv) to disambiguate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this — you're right that trajdata uses the internal clip ID as the cache key, not the UUID.
If we want a stronger guarantee, we could incorporate the nre_version_string (e.g. 25.7.8-fc8b0551) into the cache_location path to fully isolate per-version caches. How do you think of this solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, i have a similar proposal. If we add ${scenes.sceneset_path} to base_config.yaml, is it helpful to distinguish diffferent versions' usdz? I think sceneset_path is the MD5 fingerprint of all UUIDs (sorted) selected for the run — so any version change in a scene produces a different UUID, which changes the hash, which routes to a new isolated cache directory.