Skip to content

add sklearn dependency - #1286

Merged
RBendias merged 4 commits into
mainfrom
rbendias/add-sklearn-dependency
Oct 28, 2026
Merged

RBendias merged 4 commits into
mainfrom
rbendias/add-sklearn-dependency

Conversation

@RBendias

Copy link
Copy Markdown
Collaborator

No description provided.

@copy-pr-bot

copy-pr-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.90%. Comparing base (9d6c7bb) to head (e5d1f58).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1286   +/-   ##
=======================================
  Coverage   82.90%   82.90%           
=======================================
  Files         177      177           
  Lines       11451    11451           
=======================================
  Hits         9494     9494           
  Misses       1957     1957           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RBendias
RBendias marked this pull request as ready for review October 28, 2026 11:25
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9d6c7bb and e5d1f58.

Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock, !uv.lock
Files selected for processing: 2
  • THIRD_PARTY_LICENSES.md
  • pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Added scikit-learn as an optional dependency for prior-related functionality.
  • Documentation
    • Added a third-party license notice for scikit-learn.

The project adds scikit-learn to the prior optional dependency group. It also adds a third-party notice with scikit-learn’s source, license, copyright, and optional-dependency details.

Changes: scikit-learn Optional Dependency

Layer / File(s) Summary
Optional dependency and license notice
pyproject.toml, THIRD_PARTY_LICENSES.md
The prior optional dependency group includes scikit-learn. The third-party notice records its BSD 3-Clause license, copyright, optional-dependency status, and that its source code is not bundled.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: Minimal · up to e5d1f

The optional dependency can merge without an established correctness, installation, or licensing risk.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive No pull request description was provided, so the change is not documented in the description. Add a brief description stating that scikit-learn was added to the prior optional dependency group and that its third-party license was documented.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: adding scikit-learn as a dependency.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@RBendias
RBendias merged commit d488c14 into main Oct 28, 2026
7 checks passed
@RBendias
RBendias deleted the rbendias/add-sklearn-dependency branch October 28, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants