Skip to content

fix: remove digit separators from integer literals for clang-scan-deps C++ module compat #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericniebler merged 2 commits into from
Apr 20, 2026
Merged

fix: remove digit separators from integer literals for clang-scan-deps C++ module compat #2035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a54df3
fix: remove digit separators from integer literals for clang-scan-dep…
guptapratykshh Apr 19, 2026
8d4e20a
fix: revert unnecessary digit separator changes in non-preprocessor code
guptapratykshh Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/exec/detail/bwos_lifo_queue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,10 +397,10 @@ namespace experimental::execution::bwos

template <class Tp, class Allocator>
lifo_queue<Tp, Allocator>::block_type::block_type(std::size_t block_size, Allocator allocator)
: head_{0xFFFF'FFFF'0000'0000 | block_size}
: head_{0xFFFFFFFF00000000 | block_size}
, tail_{block_size}
, steal_count_{block_size}
, steal_tail_{0xFFFF'FFFF'0000'0000 | block_size}
, steal_tail_{0xFFFFFFFF00000000 | block_size}
, ring_buffer_(block_size, allocator)
{}

Expand Down
6 changes: 3 additions & 3 deletions include/exec/linux/io_uring_context.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@ namespace experimental::execution
secs = (std::max) (secs, std::chrono::seconds{0});
dur = STDEXEC::__clamp(dur,
std::chrono::nanoseconds{0},
std::chrono::nanoseconds{999'999'999});
std::chrono::nanoseconds{999999999});
return __kernel_timespec{secs.count(), dur.count()};
}
# else
Expand All @@ -1130,11 +1130,11 @@ namespace experimental::execution
__nsec -= __sec;
__nsec = STDEXEC::__clamp(__nsec,
std::chrono::nanoseconds{0},
std::chrono::nanoseconds{999'999'999});
std::chrono::nanoseconds{999999999});
__timerspec.it_value.tv_sec += __sec.count();
__timerspec.it_value.tv_nsec = __nsec.count();
STDEXEC_ASSERT(0 <= __timerspec.it_value.tv_nsec
&& __timerspec.it_value.tv_nsec < 1'000'000'000);
&& __timerspec.it_value.tv_nsec < 1000000000);
return __timerspec;
}
# endif
Expand Down
2 changes: 1 addition & 1 deletion include/exec/windows/filetime_clock.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace experimental::execution::__win32
{
public:
using rep = std::int64_t;
using ratio = std::ratio<1, 10'000'000>; // 100ns
using ratio = std::ratio<1, 10000000>; // 100ns
using duration = std::chrono::duration<rep, ratio>;

static constexpr bool is_steady = false;
Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ namespace STDEXEC
#endif

#if __has_include(<memory_resource>) && \
(defined(__cpp_lib_memory_resource) && __cpp_lib_memory_resource >= 2016'03L)
Comment thread
ericniebler marked this conversation as resolved.
(defined(__cpp_lib_memory_resource) && __cpp_lib_memory_resource >= 201603L)
# define STDEXEC_NO_STDCPP_MEMORY_RESOURCE() 0
#else
# define STDEXEC_NO_STDCPP_MEMORY_RESOURCE() 1
Expand Down