Update warp version#1624
Conversation
Greptile SummaryThis PR completes the warp-lang version update begun in #1564 by bumping the minimum version requirement to
Important Files Changed
Reviews (1): Last reviewed commit: "update warp version" | Re-trigger Greptile |
|
Warp 1.13.0 is out, and ships support for Rapids memory manager. This would in principle give us pretty good savings in memory for everywhere we use warp for something memory intensive, since we can then share with pytorch. I'd propose we shift this to 1.13 for a baseline instead of 1.11 unless there is a reason to hold at 1.11? |
|
/blossom-ci |
That is a good point. My only hesitation, 1.13 was launched only a few days ago 😅 I am open either ways. 1.11 was chosen because that is the first instance where |
17386b8 to
ed9f4e4
Compare
|
/ok to test a1e7404 |
|
GitHub CI passed. Blossom CI is down. Merging. |
* test nim inference workflow * update toml file after this merge: NVIDIA/physicsnemo#1624 * compress images * clean up debug statements * remove references to NGC artifacts * add a github ci to run pre-commit checks * address review feedback * black formatting * add cleaned up notebooks
PhysicsNeMo Pull Request
Description
This PR fixes the issue with latest version of warp, but forgets to update it in the TOML file .
#1564
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.