You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR modifies the absolute numerical tolerance used to compare fused and unfused implementations of the equivariant layer norm, which triggers on certain platforms.
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.
This PR increases the absolute tolerance for torch.float32 equivariance tests from 1e-4 to 5e-3 (a 50× relaxation) in the shared get_rtol_atol helper to accommodate platform-specific numerical differences in the fused layer norm. The change is minimal and the motivation is clear, but the new atol now equals the float16 threshold, and the Notes docstring still claims float32 delivers "~4-5 decimal digits" of precision.
Important Files Changed
Filename
Overview
test/experimental/nn/symmetry/conftest.py
Loosens float32 atol from 1e-4 to 5e-3 (50×) for layer norm equivariance tests; docstring precision claim now inconsistent with the new value.
Comments Outside Diff (1)
test/experimental/nn/symmetry/conftest.py, line 95-96 (link)
Docstring precision claim inconsistent with new atol
The Notes section still documents float32 as providing ~4-5 decimal digits of precision, but atol=5e-3 corresponds to roughly 2-3 decimal digits — the same level as float16. Consider updating the comment to reflect the actual tolerance in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
This PR modifies the absolute numerical tolerance used to compare fused and unfused implementations of the equivariant layer norm, which triggers on certain platforms.
Checklist
Dependencies
N/A
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.