Update geotransolver for 2d and 3d use cases#1502
Merged
coreyjadams merged 16 commits intoNVIDIA:mainfrom May 4, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR extends GeoTransolver with structured 2D and 3D convolutional paths, mirroring the existing Transolver structured mesh support. The refactoring extracts shared logic into reusable functions (
Important Files Changed
Last reviewed commit: a0cd8b0 |
mnabian
reviewed
Apr 14, 2026
mnabian
reviewed
Apr 14, 2026
mnabian
reviewed
Apr 14, 2026
mnabian
reviewed
Apr 14, 2026
mnabian
approved these changes
Apr 14, 2026
Collaborator
mnabian
left a comment
There was a problem hiding this comment.
LGTM! Left a few minor comments.
Refactor flare to reduce from three duplicate implementations to one.
Collaborator
Author
|
/ok to test 57981f5 |
Collaborator
Author
|
/ok to test 93084eb |
loliverhennigh
approved these changes
May 1, 2026
Collaborator
loliverhennigh
left a comment
There was a problem hiding this comment.
I think the way nn is setup is fine
Collaborator
Author
|
/blossom-ci |
…odesl, optionally
Collaborator
Author
|
/blossom-ci |
coreyjadams
added a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
This PR adds the same structured 2d and 3d convolutional steps to geotransolver that are available in transolver.
To make sure the code is not overly duplicating, it refactors a few places to ensure the implementation can reuse core components as much as possible.
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.