Expose type aliases and protocols via cuda.core.typing#1827
Merged
leofang merged 3 commits intoNVIDIA:mainfrom Apr 7, 2026
Merged
Expose type aliases and protocols via cuda.core.typing#1827leofang merged 3 commits intoNVIDIA:mainfrom
leofang merged 3 commits intoNVIDIA:mainfrom
Conversation
Add a public cuda.core.typing module that re-exports type aliases and protocols used in cuda.core API signatures (IsStreamT, DevicePointerT, VirtualMemory*T). These were previously only accessible via private module paths, which broke in v0.5.0. Closes NVIDIA#1419 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Contributor
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
leofang
added
enhancement
Member
Author
|
/ok to test fdaabf8 |
|
mdboom
approved these changes
Apr 7, 2026
Contributor
mdboom
left a comment
mdboom
left a comment
There was a problem hiding this comment.
LGTM. I'm sure we'll want to do more of this over time, but this is a good start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cuda.core.typingmodule that re-exportsIsStreamTandDevicePointerT— type annotations that appear incuda.corepublic API signatures but were previously only accessible via private module pathsapi_private.rstdocs to referencecuda.core.typing.IsStreamTandcuda.core.typing.DevicePointerTCloses #1419
Test plan
test_typing_module_imports—IsStreamTandDevicePointerTimportable fromcuda.core.typingtest_typing_matches_private_definitions— re-exports are identical objects to the private definitions-- Leo's bot