Conversation
Bump the published doc version and document the user-visible CLI changes landed since v0.0.21 for the upcoming release. - project.json / versions1.json: bump from 0.0.20 to 0.0.22, insert 0.0.21 into the version list. - commands.md > `nemoclaw <name> connect`: document the new readiness poll with NEMOCLAW_CONNECT_TIMEOUT (default 120s) that replaces the silent hang when the sandbox is not yet Ready (#466); the post-connect hint is now agent-aware and includes /exit guidance (#2080). channels list/add/remove (#2139) and nemoclaw gc (#2176) were already documented by their feature PRs. OpenShell version range bump (#2141), plugin banner live model probe (#1819), Slack Socket Mode fixes (#2085, #2146), axios proxy conflict (#2110), NIM curl timeouts (#1818), and onboard gateway bootstrap recovery (#1824) are internal behavior refinements with no doc-relevant surface change. Shields commit (#2066) skipped per docs/.docs-skip. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDocumentation updates describe new polling behavior for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Split the 46-word readiness-poll sentence into two sentences (<30 words each). - Replace the semicolon in the NEMOCLAW_CONNECT_TIMEOUT parenthetical with a comma. - Split the 32-word agent-aware hint sentence into two; this also removes the mid-clause colon since style guide limits colons to list lead-ins. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
There was a problem hiding this comment.
🧹 Nitpick comments (2)
docs/reference/commands.md (2)
207-207: Replace colon with period or conjunction.The colon here is used as general punctuation between clauses rather than to introduce a list, which violates the style guide.
As per coding guidelines: "Colons should only introduce a list. Flag colons used as general punctuation between clauses."
Suggested fix
Option 1 (period):
-The hint is agent-aware: it names the correct TUI command for the sandbox's agent and reminds you to use `/exit` to leave the chat before `exit` returns you to the host shell. +The hint is agent-aware. +It names the correct TUI command for the sandbox's agent and reminds you to use `/exit` to leave the chat before `exit` returns you to the host shell.Option 2 (conjunction):
-The hint is agent-aware: it names the correct TUI command for the sandbox's agent and reminds you to use `/exit` to leave the chat before `exit` returns you to the host shell. +The hint is agent-aware and names the correct TUI command for the sandbox's agent and reminds you to use `/exit` to leave the chat before `exit` returns you to the host shell.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/reference/commands.md` at line 207, The sentence "The hint is agent-aware: it names the correct TUI command for the sandbox's agent and reminds you to use `/exit` to leave the chat before `exit` returns you to the host shell." uses a colon as general punctuation; change it to either two sentences or add a conjunction—e.g., replace the colon with a period and start the next sentence with "It names...", or replace the colon with "and" (or "and it") so the sentence reads as a single clause; update the line containing that exact sentence in docs/reference/commands.md accordingly.
204-204: Split into separate lines (one sentence per line).This line contains two sentences. The style guide requires one sentence per line in source to make diffs readable.
As per coding guidelines: "One sentence per line in source (makes diffs readable). Flag paragraphs where multiple sentences appear on the same line."
Suggested fix
-Control the wait budget with `NEMOCLAW_CONNECT_TIMEOUT` (integer seconds; default `120`). When the deadline expires, `connect` exits non-zero with the last-seen phase. +Control the wait budget with `NEMOCLAW_CONNECT_TIMEOUT` (integer seconds; default `120`). +When the deadline expires, `connect` exits non-zero with the last-seen phase.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/reference/commands.md` at line 204, The line describing NEMOCLAW_CONNECT_TIMEOUT bundles two sentences; edit the docs entry that mentions NEMOCLAW_CONNECT_TIMEOUT and the `connect` command so each sentence is on its own line (e.g., one line: "Control the wait budget with `NEMOCLAW_CONNECT_TIMEOUT` (integer seconds; default `120`)." and a separate line: "When the deadline expires, `connect` exits non-zero with the last-seen phase."); ensure no other sentences are merged on that same line.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/reference/commands.md`:
- Line 207: The sentence "The hint is agent-aware: it names the correct TUI
command for the sandbox's agent and reminds you to use `/exit` to leave the chat
before `exit` returns you to the host shell." uses a colon as general
punctuation; change it to either two sentences or add a conjunction—e.g.,
replace the colon with a period and start the next sentence with "It names...",
or replace the colon with "and" (or "and it") so the sentence reads as a single
clause; update the line containing that exact sentence in
docs/reference/commands.md accordingly.
- Line 204: The line describing NEMOCLAW_CONNECT_TIMEOUT bundles two sentences;
edit the docs entry that mentions NEMOCLAW_CONNECT_TIMEOUT and the `connect`
command so each sentence is on its own line (e.g., one line: "Control the wait
budget with `NEMOCLAW_CONNECT_TIMEOUT` (integer seconds; default `120`)." and a
separate line: "When the deadline expires, `connect` exits non-zero with the
last-seen phase."); ensure no other sentences are merged on that same line.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0b4b3e17-1920-498e-a77b-83a6383234ab
📒 Files selected for processing (4)
.agents/skills/nemoclaw-user-reference/references/commands.mddocs/project.jsondocs/reference/commands.mddocs/versions1.json
Summary
Bumps the published doc version to
0.0.22and documents the user-visible CLI behavior changes tonemoclaw <name> connectthat landed since v0.0.21. Drafted via thenemoclaw-contributor-update-docsskill against commits inv0.0.21..origin/main, filtered throughdocs/.docs-skip.Changes
docs/project.jsonanddocs/versions1.json: bump the published version from0.0.20to0.0.22; insert a0.0.21entry into the version list so the history stays contiguous.docs/reference/commands.md→nemoclaw <name> connect: document two new behaviors.NEMOCLAW_CONNECT_TIMEOUT(integer seconds; default120) that replaces the silent hang when the sandbox is not yetReady— right after onboarding, while the 2.4 GB image is still pulling (fix(connect): add readiness poll with timeout before connecting (Fixes #430) #466)./exitto leave the chat beforeexitreturns you to the host shell (fix(connect): show agent-specific command and /exit hint (Fixes #2079) #2080).Feature PRs that shipped their own docs in the same commit are intentionally not re-documented here:
channels list/add/remove(feat(channels): add host-side channels command + block sandbox-side mutation #2139) — command reference and the "openclaw channelsblocked inside the sandbox" troubleshooting entry landed with the feature.nemoclaw gc(fix(destroy): clean up orphaned sandbox Docker images #2176) — documented as part of the destroy/rebuild image cleanup PR.Skipped per
docs/.docs-skip:e6bad533 fix(shields): verify config lock and fail hard on re-lock failure (#2066)— matchedskip-features: src/lib/shields.ts.Other commits in the range (#2141 OpenShell version bump, #1819 plugin banner live inference probe, #2085 / #2146 Slack Socket Mode fixes, #2110 axios proxy fix, #1818 NIM curl timeouts, #1824 onboard gateway bootstrap recovery, and assorted CI / test / install plumbing) are internal behavior refinements with no doc-relevant surface change.
Type of Change
Verification
npx prek run --all-filespasses for the modified files via the pre-commit hook, includingRegenerate agent skills from docs(source ↔ generated parity confirmed)npm testpasses — skipped; the one pre-existingtest/cli.test.ts > unknown command exits 1failure onorigin/mainis unrelated to these markdown/JSON-only changesmake docsbuilds without warnings (doc changes only) — not run locallyAI Disclosure
Signed-off-by: Miyoung Choi [email protected]
Summary by CodeRabbit
New Features
connectnow displays the sandbox phase while waiting for readiness and honors a configurable timeout via NEMOCLAW_CONNECT_TIMEOUT (default 120s)./exitbefore returning to the host shell.Documentation