fix(cli): support non-interactive policy preset updates (Fixes #2067)

[deepujain]

Summary

nemoclaw <sandbox> policy-add and policy-remove were prompt-only flows, which made them unusable from headless shells, CI, and NEMOCLAW_NON_INTERACTIVE=1 paths. This change adds an explicit preset-argument form so operators can script built-in preset changes without expect or an interactive TTY.

Changes

• src/nemoclaw.ts - accept policy-add <preset> and policy-remove <preset>; validate the preset name; support --yes and NEMOCLAW_NON_INTERACTIVE=1 for the explicit-preset path; fail fast with a clear usage message when non-interactive mode is requested without a preset name; update CLI help text to show the new form.
• test/policies.test.ts - add regression coverage for scripted add/remove with --yes, for the NEMOCLAW_NON_INTERACTIVE=1 path, and for the new fast-fail error when non-interactive mode is used without a preset name.

Testing

• npm run build:cli
• npm run typecheck:cli
• Manual scripted repro against the built CLI:
  • policy-add pypi --yes applies without prompting
  • NEMOCLAW_NON_INTERACTIVE=1 policy-remove pypi removes without prompting
• npm test
  • still fails in this environment with unrelated existing suite issues in src/lib/sandbox-version.test.ts, src/lib/preflight.test.ts, test/install-preflight.test.ts, and test/legacy-path-guard.test.ts

Fixes #2067

Summary by CodeRabbit

• New Features

  • Non-interactive/scripted mode for policy commands via --yes/--force flags or an env var, allowing automated apply/remove operations.
  • Ability to specify a preset name as a positional argument for direct policy selection and validation, with clear usage guidance when missing.

• Tests

  • Added tests covering scripted non-interactive flows, successful apply/remove with presets, and failure behavior when a preset is required.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Enable non-interactive/scripted execution for policy-add and policy-remove by accepting an optional positional [preset], honoring --yes/--force and NEMOCLAW_NON_INTERACTIVE=1 to skip prompts, validating presets and state transitions, and updating CLI help text accordingly.

Changes

Cohort / File(s)	Summary
Policy Command Implementation src/nemoclaw.ts	Added skipConfirm logic driven by --yes/--force flags and NEMOCLAW_NON_INTERACTIVE env var; accept optional positional [preset] (normalized/validated vs policies.listPresets()); enforce allowed state transitions (error if adding already-applied or removing not-applied); non-interactive mode fails fast if no preset provided; updated help text for [preset], --yes, and --dry-run.
Policy Command Tests test/policies.test.ts	Extended test helpers to accept envOverrides; added tests for non-interactive flows: policy-add confirmation and policy-remove confirmation verifying --yes and NEMOCLAW_NON_INTERACTIVE=1 skip prompts and call apply/remove, and that non-interactive without a positional preset errors appropriately.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through prompts and found a way,
Preset names now work in scripts all day,
With --yes or env set to one,
No TTY needed — the job gets done,
Hooray for headless play! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding non-interactive mode support for policy preset updates, which is the primary objective of the PR.
Linked Issues check	✅ Passed	The PR fully addresses all primary objectives from issue #2067: implements positional preset argument, supports --yes and NEMOCLAW_NON_INTERACTIVE=1 environment variable, validates presets, and includes comprehensive test coverage.
Out of Scope Changes check	✅ Passed	All changes in src/nemoclaw.ts and test/policies.test.ts are directly scoped to implementing non-interactive policy preset updates; no extraneous modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ericksoa]

Clean, focused feature addition. Code is correct and well-tested (6 new tests covering --yes, NEMOCLAW_NON_INTERACTIVE, and fail-fast paths for both add and remove).

One minor nit: --force is accepted in code but not shown in help() — either document it or drop it to avoid hidden API surface.

CI hasn't fully run yet (only check-pr-limit and CodeRabbit completed) — please ensure the checks workflow passes before merging.