Skip to content

Fix to release on PyPI - #569

Open
scarlehoff wants to merge 2 commits into
masterfrom
scarlehoff-patch-1
Open

Fix to release on PyPI#569
scarlehoff wants to merge 2 commits into
masterfrom
scarlehoff-patch-1

Conversation

@scarlehoff

@scarlehoff scarlehoff commented Sep 8, 2026

Copy link
Copy Markdown
Member

I thought the environment only needed to be defined in the settings, my bad.

Edit: but now I'm not sure how to do it with https://github.com/NNPDF/eko/blob/master/.github/workflows/python-poetry-pypi-with-data.yml tbh

@scarlehoff

Copy link
Copy Markdown
Member Author

As @AkshatRai07 suggested in #568 (comment) perhaps best to first try to see whether this works

@felixhekhorn felixhekhorn changed the title Fix to release pypi Fix to release on PyPI Sep 9, 2026
@felixhekhorn felixhekhorn added bug Something isn't working benchmarks Benchmark (or infrastructure) related labels Sep 9, 2026
@AkshatRai07

Copy link
Copy Markdown
Collaborator

best to first try to see whether this works

I thought it'd just require a change in some PyPI settings, but it did require an actual change to the files. Fortunately, we can run workflow again with providing a tag variable now after merging this PR, no need to wait for a tag push. I'll change the release-python.

@AkshatRai07

Copy link
Copy Markdown
Collaborator

@scarlehoff if I'm not wrong, release-ekors and release-python too require a fix like cd27bb7, right?

@scarlehoff

Copy link
Copy Markdown
Member Author

I thought it'd just require a change in some PyPI settings,

tbh, I could've also removed the environment there, but I liked the option of adding the environment best.

release-ekors and release-python too require a fix like cd27bb7, right?

Yes!

@felixhekhorn

Copy link
Copy Markdown
Collaborator

I thought it'd just require a change in some PyPI settings, but it did require an actual change to the files. Fortunately, we can run workflow again with providing a tag variable now after merging this PR, no need to wait for a tag push. I'll change the release-python.

good we can bring #561 to good use

release-ekors and release-python too require a fix like cd27bb7, right?

Yes!

Edit: but now I'm not sure how to do it with https://github.com/NNPDF/eko/blob/master/.github/workflows/python-poetry-pypi-with-data.yml tbh

just to make sure one is not relying on the other to act: @AkshatRai07 can you please take care?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarks Benchmark (or infrastructure) related bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants