Fix to release on PyPI - #569
Conversation
|
As @AkshatRai07 suggested in #568 (comment) perhaps best to first try to see whether this works |
I thought it'd just require a change in some PyPI settings, but it did require an actual change to the files. Fortunately, we can run workflow again with providing a tag variable now after merging this PR, no need to wait for a tag push. I'll change the |
|
@scarlehoff if I'm not wrong, |
tbh, I could've also removed the environment there, but I liked the option of adding the environment best.
Yes! |
good we can bring #561 to good use
just to make sure one is not relying on the other to act: @AkshatRai07 can you please take care? |
I thought the environment only needed to be defined in the settings, my bad.
Edit: but now I'm not sure how to do it with https://github.com/NNPDF/eko/blob/master/.github/workflows/python-poetry-pypi-with-data.yml tbh