-
Notifications
You must be signed in to change notification settings - Fork 9
read metadata and cards from tar without extracting multi-dim arrays #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lol782
wants to merge
7
commits into
NNPDF:master
Choose a base branch
from
lol782:fix/533-read-card-from-tar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
02a1be2
read metadata and cards from tar without extracting multi-dim arrays
lol782 cc3c080
fix the required changes
lol782 f36faea
rename legacy fixture and included EKO archive paths
lol782 e2f1ca5
added the type hints to the new functions
lol782 05d85e0
refactor: reuse metadata parsing for legacy loading
lol782 849b886
documented EKO archive card loading in changelog
lol782 d406a90
update metadata and card loader type hints with Self
lol782 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -64,19 +64,21 @@ def load(cls, path: os.PathLike): | |||||
| paths = InternalPaths(path) | ||||||
| # read raw file first to catch version | ||||||
| raw = yaml.safe_load(paths.metadata.read_text(encoding="utf-8")) | ||||||
| content = cls.from_raw(raw) | ||||||
| content._path = path | ||||||
| return content | ||||||
|
|
||||||
| @classmethod | ||||||
| def from_raw(cls, raw: dict) -> "Metadata": | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
we can use change here and also |
||||||
| """Build metadata from raw yaml, applying legacy patches.""" | ||||||
| version = parse(raw["version"]) | ||||||
| data_version = int(raw["data_version"]) | ||||||
| # patch if necessary | ||||||
| if data_version == 1: | ||||||
| if version.major == 0 and version.minor == 13: | ||||||
| raw = v1.update_metadata(paths, raw) | ||||||
| raw = v1.update_metadata(raw) | ||||||
| elif version.major == 0 and version.minor == 14: | ||||||
| raw = v2.update_metadata(paths, raw) | ||||||
|
|
||||||
| # now we are ready | ||||||
| content = cls.from_dict(raw) | ||||||
| content._path = path | ||||||
| return content | ||||||
| raw = v2.update_metadata(raw) | ||||||
| return cls.from_dict(raw) | ||||||
|
|
||||||
| def update(self): | ||||||
| """Update the disk copy of metadata.""" | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.