docs: review documentation updates for 7911e3bd1#2323
Open
github-actions[bot] wants to merge 1 commit into
Open
docs: review documentation updates for 7911e3bd1#2323github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Generated by doc-maintenance workflow. Triggered by commit 7911e3b. Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation Update Review
Triggered by commit:
7911e3bd1Generated: 2026-05-08 16:24 UTC
Compare:
b3ae1ed35d2db63f5e6e280589a45696df557b4e...7911e3bd1Affected Documents
All Changed Files in This Commit
Click to expand
DVC Setup Guide {#dvc-setup-guide}
Doc file:
docs/dvc_setup_guide.mdMatched prefixes:
pychron/dvc/Changed Files
pychron/dvc/dvc_persister.pyAI Review
Code Change Summary
The code changes introduce simulation mode protection to the DVC persister by checking
globalv.communication_simulationbefore performing data persistence operations. When simulation mode is active, bothpost_measurement_save()andsave_run_log_file()operations are skipped with warning messages to prevent simulated data from being written to DVC repositories.Documentation Updates Required
Section/Topic: Configuration fields and preference paths
Issue: The
communication_simulationglobal variable is not documented as a configuration option that affects DVC behaviorSuggested update: Add documentation for the
communication_simulationsetting, explaining that when set to True, it prevents DVC data persistence operations to avoid contaminating repositories with simulated measurement dataSection/Topic: Failure modes or troubleshooting section
Issue: Missing information about simulation mode behavior and the associated warning messages
Suggested update: Add a note that when running in simulation mode (
communication_simulation=True), users will see warning messages about skipping DVC operations, and explain that this is expected behavior to prevent simulated data from being persisted to the actual DVC repositoriesSection/Topic: DVC storage layers or data persistence workflow
Issue: The documentation may not clearly explain when and how data persistence can be bypassed
Suggested update: Include information that data persistence to DVC repositories can be conditionally disabled (such as in simulation mode) and that this affects both measurement data saves and run log file saves
This file was auto-generated by
scripts/doc_audit.py. A human must review and apply any changes to the documentation.