chore: hardening

.github/workflows/release.yml

@@ -533,30 +533,8 @@ jobs:
           cp package/Dockerfile package/deb_smoke.cpp smoke_ctx/
           cp debs/*.deb smoke_ctx/
           ls -l smoke_ctx
-          # Retry the build: the arm64 image installs deps from ports.ubuntu.com,
-          # which intermittently times out from the CI network. --no-cache on
-          # retries forces a fresh apt-get update instead of reusing a failed
-          # layer.
-          attempts=3
-          for attempt in $(seq 1 "${attempts}"); do
-            echo "::group::docker build (attempt ${attempt}/${attempts})"
-            cache_flag=""
-            if [[ "${attempt}" -gt 1 ]]; then
-              cache_flag="--no-cache"
-            fi
-            if docker build ${cache_flag} --platform ${{ matrix.docker_platform }} \
-                -t fastslide-deb-smoke smoke_ctx; then
-              echo "::endgroup::"
-              exit 0
-            fi
-            echo "::endgroup::"
-            echo "docker build failed on attempt ${attempt}/${attempts}"
-            if [[ "${attempt}" -lt "${attempts}" ]]; then
-              sleep $((attempt * 15))
-            fi
-          done
-          echo "docker build failed after ${attempts} attempts" >&2
-          exit 1
+          docker build --platform ${{ matrix.docker_platform }} \
+            -t fastslide-deb-smoke smoke_ctx
   # TEMPORARILY DISABLED: the source build pulls simpletiff from its pinned git
   # wrap (subprojects/simpletiff.wrap @ 3886522), which predates the
   # <cstdio>-before-<jpeglib.h> fix and so fails to compile under GCC. Re-enable

BUILD.bazel

@@ -499,6 +499,7 @@ cc_library(
         ":runtime_cache_interface",
         ":runtime_format_descriptor",
         ":runtime_lru_tile_cache",
+        ":runtime_path_utils",
         ":runtime_reader_registry",
         ":runtime_tile_writer",
     ],
@@ -1414,6 +1415,18 @@ cc_library(
     ],
 )
 
+cc_library(
+    name = "runtime_path_utils",
+    hdrs = ["include/fastslide/runtime/io/path_utils.h"],
+    copts = WASM_COPTS,
+    includes = ["include"],
+    visibility = ["//visibility:public"],
+    deps = [
+        "@aifocore-cpp//:result",
+        "@aifocore-cpp//:utilities-core",
+    ],
+)
+
 cc_library(
     name = "runtime_file_reader",
     srcs = ["src/runtime/io/file_reader.cpp"],
@@ -1567,27 +1580,10 @@ cc_library(
     visibility = ["//visibility:public"],
     deps = [
         ":fastslide_lib",
-        ":runtime_global_cache_manager",
         ":runtime_png_decoder",
     ],
 )
 
-# C API tile-cache tests. Require a real slide via FASTSLIDE_BENCHMARK_FILE;
-# skipped otherwise. Run with:
-#   FASTSLIDE_BENCHMARK_FILE=/abs/path/CMU-3.ndpi \
-#       bazelisk test //:cache_c_api_test --test_output=all
-cc_test(
-    name = "cache_c_api_test",
-    size = "small",
-    srcs = ["src/c/cache_c_api_test.cpp"],
-    deps = [
-        ":fastslide_c",
-        ":formats_ndpitiff",
-        "@googletest//:gtest",
-        "@googletest//:gtest_main",
-    ],
-)
-
 # Slide information tool
 cc_binary(
     name = "fastslidetool",
@@ -1916,6 +1912,17 @@ cc_test(
     ],
 )
 
+cc_test(
+    name = "path_utils_test",
+    size = "small",
+    srcs = ["src/runtime/io/path_utils_test.cpp"],
+    deps = [
+        ":runtime_path_utils",
+        "@googletest//:gtest",
+        "@googletest//:gtest_main",
+    ],
+)
+
 # Format tests
 cc_test(
     name = "aperio_metadata_parser_test",