bug fix - termination for grazed cohorts#1573
Open
rgknox wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
re-made branch using a cherry-pick |
glemieux
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is a critical bug fix, documented here:
NorESMhub/CTSM#218
This solution and changes were written by @JessicaNeedham
Summary: Cohorts were being grazed such that evergreen plants had no leaf or fine-root biomass, this was causing numerical chaos in other aspects of the model. The solution is to terminate these plants.
Collaborators:
Several, see discussion in NorESMhub/CTSM#218
Expectation of Answer Changes:
This can hypothetically change answers in all non-sp configurations, but presumably the differences would be negligable.
Description of generative AI usage (as necessary)
None AFAIK
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: