ESMF to & from grid options.#92
Open
manishvenu wants to merge 6 commits into
Open
Conversation
|
📄 Preview your docs here: |
- Remove dev testing notebook with hardcoded local path - Rename SupergridBase.from_esmf_mesh -> reconstruct_from_esmf_mesh to signal the round-trip is approximate (u/v-points interpolated, not stored) - Update docstring with warning that only q/t-points recover exactly - Add tripolar ESMF mesh tests using tx2_3v3 supergrid on GLADE - Restore self.mesh_path = file_path in Topo.write_esmf_mesh - Fix mask docstring: MOM6 and ESMF share the same convention - Fix cyclic wrap-column in reconstruct_from_esmf_mesh to use qlon_inner[:, :1] + 360 instead of hardcoded scalar 360.0
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 40.11% 41.61% +1.50%
==========================================
Files 15 15
Lines 3231 3309 +78
Branches 346 354 +8
==========================================
+ Hits 1296 1377 +81
+ Misses 1883 1878 -5
- Partials 52 54 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Move the ESMF writing to grid with an optional mask method