Bathymetry Pipeline Scaffolding#86
Open
manishvenu wants to merge 56 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stats_depth #86 +/- ##
===============================================
+ Coverage 45.42% 46.56% +1.14%
===============================================
Files 15 15
Lines 2873 2942 +69
Branches 294 306 +12
===============================================
+ Hits 1305 1370 +65
+ Misses 1516 1513 -3
- Partials 52 59 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📄 Preview your docs here: |
Rename oceanfrac -> ocean_frac to match project naming style, fix double-word typo in docstring, and standardize Parameters section format. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…o-mask bug - Merge origin/stats_depth and origin/mask_ocean_frac to pick up renames - Update calls to generate_mask_from_stats_oceanfrac -> generate_mask_from_stats_ocean_frac - Update calls to direct_stats_depth -> set_depth_from_stats - Fix direct_xesmf_depth: use src_bathymetry_dataset/destination_bathymetry (were bathymetry_output/empty_bathy) - Fix auto-mask path: call _compute_stats before generate_mask_from_stats_ocean_frac
- Rename direct_xesmf_depth -> set_depth_from_xesmf and mpi_direct_xesmf_depth -> mpi_set_depth_from_xesmf to match set_depth_from_stats pattern - Add test_diagnose_resolution_below_threshold and _above_threshold - Add test_set_from_dataset_stats_path covering the ocean_frac mask + stats depth workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is where I take set_from_dataset from the OLD method (Ashley Barnes regional-mom6), to the NEW workflow!
I am happy how this turned out!
Docs: https://docs.google.com/document/d/11rGmyRcyXVK9AzdFeHzhjYPSUH9jPjWLqE35222BSkQ/edit?tab=t.0
Package Docs are going to come much later. It's very annoying to write docs when there's so many seperate PRs.
Closes CROCODILE-CESM/CrocoDash#192