Display Stats in the Topo Editor on zoom#84
Open
manishvenu wants to merge 56 commits into
Open
Conversation
|
📄 Preview your docs here: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 40.11% 39.28% -0.83%
==========================================
Files 15 15
Lines 3231 3319 +88
Branches 346 366 +20
==========================================
+ Hits 1296 1304 +8
- Misses 1883 1962 +79
- Partials 52 53 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Replace all _topo_stats references with topo.stats (the public property on Topo that delegates to src._computed_stats); the old attribute name never existed, so stats buttons and overlay were permanently inert - Normalize qlon to [0, 360) in _on_zoom_change to match xlim normalization, and handle the wrap-around case when the view crosses the 0/360 boundary - Remove duplicate on_click registrations for stat buttons (each fired twice) - Remove unused _stats_text annotation that was created but never shown
- from_ds: gracefully handle missing 'radius' attr with a warning that dx, dy, and area cannot be recalculated without the original radius - topo.py:1372: use self.tmask instead of non-existent self.mask
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REPLACES #77
Changes:
Once the zoom reaches a threshold (40 cells) show the cell stats in the cell
Create new buttons to set the depth to those stat numbers if wanted.
Question:
You can use the buttons even if you don't see the stats, which only show up when you zoom in. Is that good behavior?