Masking in Topo Editor + Rectangle Selector#83
Conversation
|
📄 Preview your docs here: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 40.71% 46.24% +5.52%
==========================================
Files 14 14
Lines 2655 2742 +87
Branches 274 287 +13
==========================================
+ Hits 1081 1268 +187
+ Misses 1529 1409 -120
- Partials 45 65 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alperaltuntas
left a comment
alperaltuntas
left a comment
There was a problem hiding this comment.
I left a couple of comments, but more importantly, I am unable to test these changes because TopoEditor doesn't work in jupyter via the mom6_forge conda environment. I am getting:
ImportError: libpmi.so.0: cannot open shared object file: No such file or directory
when I attempt to run TopoEditor via the (newly installed) mom6_forge conda environment. We need to fix that issue first before I can evaluate this PR.
| def active_cells(self): | ||
| if hasattr(self, "_selected_cells") and self._selected_cells: | ||
| return list(self._selected_cells) | ||
| elif self._selected_cell is not None: |
There was a problem hiding this comment.
This elif statement doesn't make sense to me. If the above if statement evaluates to true, then this elif branch will be skipped. If the if statement is false, then this elif branch will be false too, or will lead to a runtime error.
There was a problem hiding this comment.
Ahh that's maybe my bad. The different is an "s": selected_cells, versus selected_cell. Want me to change that to more different?
| # Git/domain controls | ||
| self._git_create_branch_button.on_click(self.on_git_create_branch) | ||
| self._git_checkout_button.on_click(self.on_git_checkout) | ||
| self._display_mode_toggle.observe( |
There was a problem hiding this comment.
Why is this observe call no longer necessary?
There was a problem hiding this comment.
It was repeated twice.
|
@alperaltuntas, I am unable to reproduce your error directly, I tightened up the ipympl to be <0.10.0 and fixed a seperate error so that potentially may help. |
…ids and antimeridian crossing
3 participants
Replaces #76 , Closes CROCODILE-CESM/CrocoDash#134
Changes:
Add the mask variable to the topo editor in the form of using the topo mask property and adding a mask edit field that can be switched from land to ocean
Add a toggle to do rectangle select, to set large chunks of bathymetry to a specific value
Minor cleaning