Support Mouse Move and avoid crashing when load some games#33
Open
yosanyu wants to merge 79 commits into
Open
Conversation
I think I was ending up in people's spam also professionalism lol
…g file (N7Alpha#20) * Added function declaration for load_cfg_file() * Added load_cfg_file() to load core options load_cfg_file() loads a [core].cfg file with libretro core options, and is called between the load() and load_game() functions.
This reverts commit adc678c. - I replaced this with an in editor method of setting core options as well as a GlobalCoreOptions map that can be configured in an .ini check out UnrealLibretro.ini for an example - I feel bad immediately reverting the first contribution however I do think this new method is more intuitive and more in line with Unreal Engine conventions
Older versions of Unreal need this
This is a tiny bit safer and more clear though less performant
This fixes MotionController behavior on 4.26 and beyond
Modifying options is lockfree (important for gamethread) Also I made certain data races impossible
* Create setup.cmd Equivalent of setup.sh for Windows users. * Make script a little more user friendly
- This is supposed to be optional some cores don't implement it though
This has slightly different semantics than how Retroarch handles it... Retroarch allows setting the controller to NONE unconditionally whereas I only allow it if the core set any controller descriptions. This made the implementation slightly simpler
- UAT copies every file unconditionally in your plugin directory when building the plugin. This would lead to quadratic io with respect to number of plugins being packaged
Owner
|
I'll try merging this by cherry picking the last commit. I think I'll just have to close this PR though if I do that but you will have authorship of the commit. I'll probably do this once I merge the |
…fault.cfg and everyrom.cfg I think mame series need this update
Author
|
I call unload_game() before deinit() because, when using the MAME 2003-Plus core, it doesn’t save default.cfg and <rom_name>.cfg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cloned from the master branch so there might be some issues with merging
Support movement values for the mouse's X and Y axes, and avoid crashing due to failures in loading certain cores or ROMs.
However, I now that if I use the parallel_n64 core, it still crashes.