Skip to content

test: check pooled per-object blob digest in antithesis observer#3493

Merged
halfprice merged 1 commit into
mainfrom
zhewu/add_pooled_blob_consistency_check_in_antithesis
Jun 30, 2026
Merged

test: check pooled per-object blob digest in antithesis observer#3493
halfprice merged 1 commit into
mainfrom
zhewu/add_pooled_blob_consistency_check_in_antithesis

Conversation

@halfprice

Copy link
Copy Markdown
Collaborator

Summary

Mirrors the simtest wiring from #3490 into the Antithesis cross-node invariant observer.

#3490 added the walrus_per_object_pooled_blob_info_consistency_check gauge and verified it across nodes in the simtest BlobInfoConsistencyCheck. This PR adds the equivalent check to the Antithesis side: the observer (docker/walrus-antithesis/build-test-config-image/files/run-observer.sh) scrapes Prometheus metrics from all storage nodes and crashes on cross-node divergence, which Antithesis surfaces as a test failure.

Changes

  • Added walrus_per_object_pooled_blob_info_consistency_check as a new hard invariant (per-epoch digest must match across all nodes), mirroring the existing per-object check:
    • Same MAX_EPOCH_BUCKETS bucket-saturation guard (skip comparison near wraparound to avoid false positives).
    • Same NO_DATA_PATIENCE silent-regression guard (crash if no common data for too long).
    • Crash on mismatched digests across nodes.
  • Renumbered the event-source check to hard invariant 4; updated header docs and added a per_object_pooled_no_data_streak counter.

Testing

  • bash -n passes; shellcheck pre-commit hook passes.

Mirror the simtest wiring from #3490 into the Antithesis cross-node
invariant observer. The observer scrapes Prometheus metrics from all
storage nodes and crashes on cross-node divergence, which Antithesis
surfaces as a test failure.

Add walrus_per_object_pooled_blob_info_consistency_check as a new hard
invariant alongside the regular per-object check: same epoch-bucket
saturation guard, same no-data silent-regression guard, and crash on
mismatched digests across nodes.
@halfprice halfprice requested a review from shuowang12 June 28, 2026 04:59
@halfprice halfprice enabled auto-merge (squash) June 28, 2026 04:59

@shuowang12 shuowang12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@halfprice halfprice merged commit 8051929 into main Jun 30, 2026
28 checks passed
@halfprice halfprice deleted the zhewu/add_pooled_blob_consistency_check_in_antithesis branch June 30, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants