feat: create blob info snapshot checkpoints at the epoch boundary#3468
Draft
shuowang12 wants to merge 1 commit into
Draft
feat: create blob info snapshot checkpoints at the epoch boundary#3468shuowang12 wants to merge 1 commit into
shuowang12 wants to merge 1 commit into
Conversation
When enabled via the new `blob_info_snapshot` config section (off by default), the storage node creates a RocksDB checkpoint of its database at the epoch boundary, directly after garbage-collection phase 1 and before any further events are processed, and removes older checkpoints so at most one exists at a time. Startup finishes any cleanup that was interrupted by a crash, so a stale checkpoint cannot pin deleted SST files for a full epoch. At that boundary point the blob info tables are identical across all honest nodes, so the checkpoints allow verifying blob info determinism across nodes offline. Checkpoint errors are logged and counted but never fail epoch processing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Warning: This PR modifies one of the example config files. Please consider the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabled via the new
blob_info_snapshotconfig section (off by default), the storage node creates a RocksDB checkpoint of its database at the epoch boundary, directly after garbage-collection phase 1 and before any further events are processed, and removes older checkpoints so at most one exists at a time. Startup finishes any cleanup that was interrupted by a crash, so a stale checkpoint cannot pin deleted SST files for a full epoch.At that boundary point the blob info tables are identical across all honest nodes, so the checkpoints allow verifying blob info determinism across nodes offline. Checkpoint errors are logged and counted but never fail epoch processing.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)