Skip to content

Add version requirements for dependencies #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Murmele merged 2 commits into from
Jun 14, 2026
Merged

Add version requirements for dependencies #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58f3e08
Add minimum version for system dependencies
AHSauge May 28, 2026
35ba8d1
Fix outdated versions in README
AHSauge May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ else()
CACHE BOOL "Use ssh")
find_pkglibraries(LIBSSH2 libssh2)
if(NOT LIBSSH2_FOUND)
find_package(libssh2 REQUIRED)
find_package(libssh2 1.11 REQUIRED)
endif()
endif()

Expand Down Expand Up @@ -143,7 +143,7 @@ else()
endif()

find_package(
Qt6
Qt6 6.6
COMPONENTS ${QT_MODULES} LinguistTools
REQUIRED)
if(FLATPAK)
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Build Environment
* Windows - MSVC >= 2017 recommended
* Linux - GCC >= 6.2 recommended
* macOS - Xcode >= 10.1 recommended
* CMake >= 3.3.1
* CMake >= 3.19
* Ninja (optional)

Dependencies
Expand All @@ -74,7 +74,7 @@ submodules are optional or may also be satisfied by system libraries.

**External Dependencies**

* Qt (required >= 5.12)
* Qt (required >= 6.6)

**Included Dependencies**

Expand Down
2 changes: 1 addition & 1 deletion dep/cmark/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
if(USE_SYSTEM_CMARK)
if(PKG_CONFIG_FOUND)
pkg_check_modules(CMARK libcmark)
pkg_check_modules(CMARK libcmark>=0.30.2)
add_executable(cmark_exe IMPORTED GLOBAL)
set_property(TARGET cmark_exe PROPERTY IMPORTED_LOCATION cmark)
endif()
Expand Down
2 changes: 1 addition & 1 deletion dep/hunspell/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pkg_check_modules(HUNSPELL hunspell)
pkg_check_modules(HUNSPELL hunspell>=1.7)

if(HUNSPELL_FOUND)
add_library(hunspell INTERFACE)
Expand Down
2 changes: 1 addition & 1 deletion dep/libgit2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ if(WIN32)
endif()

if(USE_SYSTEM_LIBGIT2)
pkg_check_modules(LIBGIT2 REQUIRED libgit2)
pkg_check_modules(LIBGIT2 REQUIRED libgit2>=1.9)
else()
set(BUILD_CLI OFF)
add_subdirectory(libgit2)
Expand Down
2 changes: 1 addition & 1 deletion dep/libssh2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
if(USE_SYSTEM_LIBSSH2)
if(PKG_CONFIG_FOUND)
pkg_check_modules(LIBSSH2 REQUIRED libssh2)
pkg_check_modules(LIBSSH2 REQUIRED libssh2>=1.11)
endif()

else()
Expand Down
2 changes: 1 addition & 1 deletion dep/lua/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
find_package(Lua)
find_package(Lua 5.3)
if(LUA_FOUND)
add_library(lua INTERFACE)
target_include_directories(lua INTERFACE ${LUA_INCLUDE_DIR})
Expand Down
2 changes: 1 addition & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ macro(test)
endif()

if(WIN32)
find_package(Qt6Gui)
find_package(Qt6Gui 6.6)
string(REPLACE ";" "\;" NEWPATH "$ENV{PATH}")
string(REPLACE ";" "\;" PLUGIN_PATH
"$<TARGET_FILE_DIR:Qt6::QOffscreenIntegrationPlugin>")
Expand Down
Loading