Skip to content

fix: refactoring the codebase - #137

Open
eltoukhi392003 wants to merge 3 commits into
MuNuChapterHKN:developfrom
eltoukhi392003:mohamed/refactoring-codebase
Open

fix: refactoring the codebase#137
eltoukhi392003 wants to merge 3 commits into
MuNuChapterHKN:developfrom
eltoukhi392003:mohamed/refactoring-codebase

Conversation

@eltoukhi392003

Copy link
Copy Markdown

No description provided.

@pasc4le pasc4le left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job Mohamed! Finally the repo feels more readable. I've left you some comments on some more things we can delete, but we're on a very good track. Thank you for the submission.

Comment thread .husky/pre-commit

@pasc4le pasc4le May 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also add pretty-quick, check it out at https://www.npmjs.com/package/pretty-quick?activeTab=readme

Comment thread data/recognitions.ts Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used at all?

Comment thread data/Activities/events.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as here.

Comment thread service/mailService.ts Outdated

@pasc4le pasc4le May 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely not used anymore

Comment thread pages/api/directus.ts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the directus client in this file can be set globally at top. Instead of repeating the same const directus = createDirectus(API_URL).with(rest()); over and over.

Comment thread pages/api/telegram.ts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is also not used anywhere. Double check though.

@pasc4le
pasc4le changed the base branch from main to develop May 14, 2026 14:23
@pasc4le pasc4le changed the title Mohamed/refactoring codebase fix: refactoring the codebase May 14, 2026
@pasc4le

pasc4le commented May 14, 2026

Copy link
Copy Markdown
Member

One thing, this will be merged for last. @marcofabiani12 is working at the responsiveness of the website, once he's finished doing that task, we're gonna rebase over develop branch and reformat his changes based on the prettier rules define here.

This will prevent us from having to do a lot of work twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants