Add top-level standardized start/stop scripts (CRS_PORT_HTTP) - #8
Merged
Conversation
Adds top-level start-mu2edaq-resource-manager.sh / stop-mu2edaq-resource-manager.sh, the standardized names the Mu2e control room (crs-app) expects. The start script maps CRS_PORT_HTTP (default 8080) to RM_PORT and starts the server in daemon mode via scripts/start_server.sh; the stop script delegates to scripts/stop_server.sh. The existing scripts/ entry points are unchanged. Closes #5 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds control-room–standard top-level start/stop entrypoint scripts for the Mu2e DAQ Resource Manager, aligning with the dispatcher’s expected script names and providing a CRS_PORT_HTTP environment mapping for the service port.
Changes:
- Added
start-mu2edaq-resource-manager.shwrapper that mapsCRS_PORT_HTTPtoRM_PORTand starts the server in daemon mode viascripts/start_server.sh. - Added
stop-mu2edaq-resource-manager.shwrapper that delegates toscripts/stop_server.sh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| start-mu2edaq-resource-manager.sh | New standardized top-level start wrapper, sets env and delegates to existing start script. |
| stop-mu2edaq-resource-manager.sh | New standardized top-level stop wrapper delegating to existing stop script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
|
|
||
| export RM_PORT="${CRS_PORT_HTTP:-${RM_PORT:-8080}}" |
Comment on lines
+9
to
+10
| # Port precedence: CRS_PORT_HTTP env > RM_PORT env > built-in default (8080, | ||
| # matching apps.yaml). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #5.
start-mu2edaq-resource-manager.sh/stop-mu2edaq-resource-manager.sh, the standardized names the control room dispatcher (crs-app start|stop resource-manager) expects.start-mu2edaq-resource-manager.shmapsCRS_PORT_HTTP(default 8080, matching apps.yaml) toRM_PORTand starts in daemon mode viascripts/start_server.sh.stop-mu2edaq-resource-manager.shdelegates toscripts/stop_server.sh.scripts/start_server.sh/scripts/stop_server.share left unchanged (these are thin top-level wrappers around them).Closes #5
🤖 Generated with Claude Code