-
Notifications
You must be signed in to change notification settings - Fork 52
feat(cashu): Track B - release happy path #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
a1denvalu3
wants to merge
24
commits into
MostroP2P:feat/cashu-mostro-core-0.12
Choose a base branch
from
a1denvalu3:feature/cashu-track-b
base: feat/cashu-mostro-core-0.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
bc24a88
feat(cashu): implement Track B - release happy path
a1denvalu3 924f1b6
feat(cashu): send P_M signature to buyer on release
a1denvalu3 bab00e4
feat(bond): Phase 4.5 — re-prompt winner for payout invoice on paymen…
grunch 828114b
feat(bond): Phase 5 — maker bond (non-range) + dispute slash (#767)
grunch eed5ede
docs: document daemon event kinds (#769)
ermeme[bot] c7db272
feat(price): Phase 1 — Yadio provider + PriceManager wiring (#753)
grunch af8f05d
feat(bond): Phase 6 — range-order maker bond with proportional slashe…
grunch c610c34
fix(price): repair test-only price seeding broken by #753/#770 merge …
grunch be1bd5a
feat(bond): Phase 7 — maker timeout slash (#775)
grunch 1d6c5ba
docs(bond): Phase 8 — public config exposure + operator docs (#777)
grunch 14299b1
feat(price): Phase 2 — direct backup quoters + multi-source aggregati…
grunch ed10678
Update CHANGELOG for version 0.17.5
grunch 5b07be2
chore: Release mostro version 0.17.5
grunch ba86102
feat(transport): Phase 1 — wire protocol v2 (NIP-44 direct) into most…
grunch 68a125e
feat(bond): notify slashed party on dispute slash (#768) (#779)
Catrya 23b759b
feat(transport): Phase 2 — anti-spam gates for protocol v2 (#780)
grunch 4c8259b
feat(transport): log active transport at mostrod startup (#781)
grunch 5801afe
fix(nip33): rename info tag protocol_versions -> protocol_version (#782)
grunch 82f1923
feat(price): Phase 3 — El Toque fiat-cross provider (CUP/MLC) (#778)
grunch 4a6722a
fix: surface InvalidOrderId to clients as CantDo(NotFound) (#752)
AndreaDiazCorreia 6802c97
feat(transport): stamp inner protocol version to match active transpo…
grunch f64e93b
ci(mutation): run as scheduled audit + opt-in, not on every push to m…
grunch 2514856
fix(cashu): harden release happy path and fix CI blockers
grunch ee9532e
Merge remote-tracking branch 'origin/main' into feature/cashu-track-b
grunch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log errors during Cashu signature generation to aid debugging.
The nested
if let Ok(...)chains silently discard errors from token parsing, key conversion, and signing. If any step fails, the buyer may receive noCashuPmSignature(or partial signatures), and there's no diagnostic trail. Since P_M signatures are critical for the buyer to redeem the Cashu escrow, failures here should be logged.Proposed fix with error logging
📝 Committable suggestion
🤖 Prompt for AI Agents