Skip to content

chore: trim comments in src/fetch - #36

Merged
BraCR10 merged 1 commit into
developmentfrom
chore/comments-fetch-module
Jul 30, 2026
Merged

chore: trim comments in src/fetch#36
BraCR10 merged 1 commit into
developmentfrom
chore/comments-fetch-module

Conversation

@BraCR10

@BraCR10 BraCR10 commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary

Trims doc comments and inline comments across the fetch module (client.rs, filters_summary.rs), dropping internal spec/requirement/PR references entirely. Comment-only change, no logic touched.

Removed:

  • Citations to internal spec/FR/PR/task-ID references throughout
  • Test doc comments that only restated the test function's own name

Kept (shortened where possible):

  • The empirical rationale behind the progress-indicator threshold
  • The ordered-relay-list merge rationale (a real ordering bug fixed earlier)
  • The relay URL canonicalization rationale (a real false-negative bug fixed earlier)
  • The EventSource two-method split rationale
  • The nostr-relay-pool panic-isolation rationale for spawning fetch in its own task
  • Per-field semantics on RelayFetchOutcome and the has_no_usable_events gate

Test plan

  • cargo build --all-targets
  • cargo test (378 tests, unchanged count)
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo fmt --check
  • Diff limited to comment-only lines

Rewrites doc comments and inline comments in the fetch module to be
shorter and drop internal spec/requirement/PR references. Comment-only
change, no logic touched.
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@BraCR10, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eb9ea870-b46a-47d6-b40e-f74df7f48ac2

📥 Commits

Reviewing files that changed from the base of the PR and between b7ddfa1 and c315005.

📒 Files selected for processing (2)
  • src/fetch/client.rs
  • src/fetch/filters_summary.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BraCR10
BraCR10 merged commit d709e43 into development Jul 30, 2026
4 checks passed
@BraCR10
BraCR10 deleted the chore/comments-fetch-module branch July 30, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant