fix(invoice): keep Submit reachable on Add Lightning Invoice when keyboard is open (#635) - #636
fix(invoice): keep Submit reachable on Add Lightning Invoice when keyboard is open (#635)#636codaMW wants to merge 1 commit into
Conversation
…stays reachable with keyboard open Wraps the invoice form Column in a SingleChildScrollView. On smaller or taller-keyboard viewports the Column overflowed when the soft keyboard shrank the available height, clipping the Submit button's hit area so taps did nothing (issue MostroP2P#635). Scrolling keeps the button reachable on any screen size. Fixes MostroP2P#635
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe build method of the lightning invoice widget is updated so its content is wrapped in a SingleChildScrollView instead of a plain Column, while retaining the same instruction text, form field, and cancel/submit buttons. ChangesScrollable Lightning Invoice Widget
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review Summary
Verdict: Approve
I don’t see a blocking issue in this diff. Wrapping the invoice form in a SingleChildScrollView is the right fix for the keyboard/viewport overflow.
Suggestion
- Add a small widget regression test for the narrow-screen + keyboard-open case. This bug is geometry-specific, so having an automated guard would be useful.
Looks good
- The change is minimal and localized.
- The existing input/cancel/submit wiring is preserved.
- No obvious state, async, or security regressions introduced.
Summary by CodeRabbit