fix: write metas file atomically - #105
Merged
weixiao-huang merged 1 commit intoSep 4, 2026
Merged
Conversation
WangXukang-cypher
force-pushed
the
fix/atomic-metas-file-write
branch
from
September 4, 2026 12:03
10da00d to
b44c816
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Write the exported metas file atomically in
examples/update.pyby writing to a temporary file, fsyncing it, and replacing the target path only after the write completes.Also wrap metas file loading errors with a clearer message so interrupted or truncated saves are reported as corrupted metadata instead of surfacing a low-level JSON validation error.
Test Plan
python -m py_compile examples\update.pygit diff --checkpython -m pre_commit run --all-files --show-diff-on-failure