Repository navigation
Decide the bytes return of a MEOS byte buffer where the wrapper is built - #44
Merged
estebanzimanyi merged 1 commit intoOct 31, 2026
Conversation
build_function_string returns a single bytes object for a function whose return is uint8_t * and whose one output parameter is a size_t *, reading the two types it builds the wrapper from, as apply_input_arrays takes a uint8_t input array as bytes. The text modifier that rewrote each generated wrapper of that shape after the fact, byte_array_modifier, and the catalog lookup that selected it are removed. Measured: from one catalog of MobilityDB master b3be2105fd, the generator writes functions.py and __init__.py byte for byte as before, the 48 byte buffer functions returning bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_function_string returns a single bytes object for a function whose
return is uint8_t * and whose one output parameter is a size_t *, reading
the two types it builds the wrapper from, as apply_input_arrays takes a
uint8_t input array as bytes. The text modifier that rewrote each generated
wrapper of that shape after the fact, byte_array_modifier, and the catalog
lookup that selected it are removed.
Measured: from one catalog of MobilityDB master b3be2105fd, the generator
writes functions.py and init.py byte for byte as before, the 48 byte
buffer functions returning bytes.