Repository navigation
Register the forms a trailing SQL default allows for the set path functions - #538
Merged
estebanzimanyi merged 1 commit intoOct 30, 2026
Conversation
…ctions
MobilityDB declares jsonbsetExtractPath and jsonbsetExtractPathText with
null_handle text DEFAULT 'use_json_null', and jsonbsetInsert with after
boolean DEFAULT false. shape_text_array registers the path functions over
a set, and shape_sig_call, which registers the forms a default allows,
reads no set operand, so the set functions register their full form
alone.
shape_text_array registers, for a set operand, each form its trailing
defaults allow: text_array_default_forms states each shorter tail, the
omitted argument a literal sig_call_literal converts from its default,
and each form is its own body, Gen_<fn>_v<k>, beside the full one.
Witness: jsonbsetExtractPath(set([jsonb '{"a":{"b":7}}']), ['a','b'])
finds no function on main, where the extension lists the three-argument
form alone; it answers {7}, as MobilityDB does.
Measured: the generator run before and after the change on the catalog of
the pinned MEOS e87fd59846 registers 10103 and 10106 signatures: three
added, jsonbsetExtractPath and jsonbsetExtractPathText without their null
handling and jsonbsetInsert without its after, and none removed. The new
bodies call jsonbset_extract_path with
null_handle_type_from_string("use_json_null") and jsonbset_insert with
false.
Tests: value_type_sets.test runs each short form against its full form
with the default passed.
Why: a binding registers the SQL surface MobilityDB declares, and a call
leaving a defaulted argument out is part of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MobilityDB declares jsonbsetExtractPath and jsonbsetExtractPathText with
null_handle text DEFAULT 'use_json_null', and jsonbsetInsert with after
boolean DEFAULT false. shape_text_array registers the path functions over
a set, and shape_sig_call, which registers the forms a default allows,
reads no set operand, so the set functions register their full form
alone.
shape_text_array registers, for a set operand, each form its trailing
defaults allow: text_array_default_forms states each shorter tail, the
omitted argument a literal sig_call_literal converts from its default,
and each form is its own body, Gen__v, beside the full one.
Witness: jsonbsetExtractPath(set([jsonb '{"a":{"b":7}}']), ['a','b'])
finds no function on main, where the extension lists the three-argument
form alone; it answers {7}, as MobilityDB does.
Measured: the generator run before and after the change on the catalog of
the pinned MEOS e87fd59846 registers 10103 and 10106 signatures: three
added, jsonbsetExtractPath and jsonbsetExtractPathText without their null
handling and jsonbsetInsert without its after, and none removed. The new
bodies call jsonbset_extract_path with
null_handle_type_from_string("use_json_null") and jsonbset_insert with
false.
Tests: value_type_sets.test runs each short form against its full form
with the default passed.
Why: a binding registers the SQL surface MobilityDB declares, and a call
leaving a defaulted argument out is part of it.