[ALFMOB-423] Run CI once per push - #82
Draft
amccall-mindera wants to merge 1 commit into
Draft
Conversation
ci.yaml fired on both push and pull_request, running test-and-lint twice for any branch with an open PR. The pull_request run is a strict superset (it also runs smoke integration tests), so the push run was fully redundant. Rely on pull_request only; cd.yaml still covers push-to-main/release. run-smoke-tests is now always true. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
pushtrigger from.github/workflows/ci.yamlso CI runs once per push instead of twice.run-smoke-testsis simplified to a constanttrue.Why
ci.yamlfired on bothpush(branches-ignore: main, release/**) andpull_request. Any branch with an open PR therefore ran the reusabletest-and-lintworkflow twice on every push:The
pull_requestrun is a strict superset, so the push run was fully redundant whenever a PR was open — it only added value before a PR existed, and draft PRs already triggerpull_request. Post-merge validation onmain/release/**is handled bycd.yaml(on: push), so nothing is lost there.How
ci.yamlnow triggers onpull_requestonly.run-smoke-tests: ${{ github.event_name == 'pull_request' }}→run-smoke-tests: true(the event is alwayspull_requestnow, so the conditional was dead).Test
test-and-lintrun should appear (the pull_request one), and it should run the smoke integration tests.cd.yamlis untouched; push-to-main/release behaviour is unchanged.Trade-off (accepted, per ticket): a branch gets no CI until a PR — including a draft — is opened.
See
Link to JIRA: ALFMOB-423