Skip to content

[fix] auto-replenish: infinite loops #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wide-Cat merged 5 commits into from
Sep 25, 2025
Merged

[fix] auto-replenish: infinite loops #5715

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28a381c
[fix] auto-replenish: infinite loops
31a05b9c Sep 23, 2025
dfc1077
[fix]
31a05b9c Sep 23, 2025
d67784a
[fix] a subtle logic error
31a05b9c Sep 23, 2025
640203a
[fix] offhand
31a05b9c Sep 25, 2025
4bee267
[fix] actually it was even more broken than that
31a05b9c Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/meteordevelopment/meteorclient/systems/modules/player/AutoReplenish.java
View file
Open in desktop
Comment thread
31a05b9c marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import meteordevelopment.meteorclient.systems.modules.Modules;
import meteordevelopment.meteorclient.systems.modules.combat.AutoTotem;
import meteordevelopment.meteorclient.utils.player.InvUtils;
import meteordevelopment.meteorclient.utils.player.SlotUtils;
import meteordevelopment.orbit.EventHandler;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
Expand Down Expand Up @@ -151,6 +152,10 @@ private void checkSlot(int slot, ItemStack stack) {
fromSlot = findItem(prevStack, slot, 1);
}

// eliminate occasional loops when moving items from hotbar to itself
if (fromSlot == mc.player.getInventory().getSelectedSlot()) return;
if ((fromSlot < 9 || fromSlot == SlotUtils.OFFHAND) && fromSlot < slot && slot != mc.player.getInventory().getSelectedSlot()) return;

InvUtils.move().from(fromSlot).to(slot);
}

Expand All @@ -164,7 +169,7 @@ private int findItem(ItemStack lookForStack, int excludedSlot, int goodEnoughCou
ItemStack stack = mc.player.getInventory().getStack(i);
if (stack.getItem() != lookForStack.getItem()) continue;

if (sameEnchants.get() && !stack.getEnchantments().equals(lookForStack.getEnchantments())) continue;
if (sameEnchants.get() && !stack.getComponents().equals(lookForStack.getComponents())) continue;
Comment thread
31a05b9c marked this conversation as resolved.
Outdated

if (stack.getCount() > count) {
slot = i;
Expand Down