feat: Accounts Metrics

[owencraston]

Description

MetaMask currently tracks number_of_hd_entropies in Segment, but the value has become inaccurate: it was
derived from KeyringController keyrings rather than AccountsController internal accounts, and it had no
awareness of BIP-44 multichain account groups (where a single user "account" produces one address per
supported network). This made it impossible to accurately answer questions like "how many accounts does
the average MetaMask user have?" or segment users by hardware wallet adoption.

This PR replaces the old keyring-based tracking with a reliable, controller-driven implementation that
derives all wallet composition traits from AccountsController.internalAccounts — the same source of
truth used on Extension — so traits remain accurate regardless of wallet lock state.

What's changing

New and updated user traits emitted on the Segment identify call:

  │            Property            │  Type   │                       Description                       │
  ├────────────────────────────────┼─────────┼─────────────────────────────────────────────────────────┤
  │ number_of_hd_entropies         │ integer │ Count of unique SRP sources, deduped by entropy.id      │
  │                                │         │ (fixes existing inaccurate value)                       │
  ├────────────────────────────────┼─────────┼─────────────────────────────────────────────────────────┤
  │ number_of_account_groups       │ integer │ BIP-44 account groups deduped by entropy.id:groupIndex  │
  │                                │         │ — what users see as "accounts" in the UI                │
  ├────────────────────────────────┼─────────┼─────────────────────────────────────────────────────────┤
  │ number_of_imported_accounts    │ integer │ Accounts added via raw private key (Simple Key Pair     │
  │                                │         │ keyring)                                                │
  ├────────────────────────────────┼─────────┼─────────────────────────────────────────────────────────┤
  │ number_of_ledger_accounts      │ integer │ Account groups from Ledger hardware wallet              │
  ├────────────────────────────────┼─────────┼─────────────────────────────────────────────────────────┤
  │ number_of_qr_hardware_accounts │ integer │ Account groups from QR-based hardware wallets           │
  │                                │         │ (Keystone, OneKey, etc.)                                │
  ├────────────────────────────────┼─────────┼─────────────────────────────────────────────────────────┤
  │ number_of_hardware_wallets     │ integer │ Count of distinct hardware wallet device types in use   │
  │                                │         │ (Ledger + QR)                                           │
  └────────────────────────────────┴─────────┴─────────────────────────────────────────────────────────┘

▎ Total wallet count can be derived in Segment as: number_of_hd_entropies + number_of_hardware_wallets +
▎ number_of_imported_accounts

Trezor and Lattice are intentionally excluded — those hardware wallets are not supported on mobile.

Implementation

• getAccountCompositionTraits() iterates internalAccounts.accounts, classifies each account by
  metadata.keyring.type, and deduplicates BIP-44 multichain addresses using the
  options.entropy.id:groupIndex composite key so multiple chain addresses for the same account group count
  as one.
• Traits are included in every identify call via generateUserProfileAnalyticsMetaData().
• A subscription to AccountsController:stateChange in analytics-controller-init.ts re-fires the identify
  call whenever account composition changes, with two guards to avoid unnecessary calls:
  a. A selector narrows the subscription to internalAccounts.accounts, skipping pure selectedAccount
  changes.
  b. A composition fingerprint (hashing only keyring type and entropy fields) skips analytics.identify()
  when lastSelected or account names change but composition hasn't.
• The old useEffect in the Wallet view that tracked number_of_hd_entropies via hdKeyrings.length is
  removed.

Equivalent extension changes: MetaMask/metamask-extension#41918

Changelog

CHANGELOG entry: Update metrics to track wallet composition (number of accounts, number of hardware wallets etc).

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1757

Manual testing steps

1. Build the extension locally
2. Monitor the sentry events with the following steps: Mobile docs
   • set export IS_TEST="false" in your .js.env
   • open the react native debugger console by pressing j inside the metro server
   • Open the console and filter by IDENTIFY event
   • Pro tip: set your unlock time to never in settings. If the device is locked you'll need to re open the debugger all over again.
3. import/create a wallet
4. you should notice the initial Identify event received logged with the correct number_of_account_groups logged as well as number_of_hd_entropies
5. import a private key
6. notice the Identify event received logged with the updated number_of_account_groups and number_of_imported_accounts
7. Import a new SRP with X accounts. You the identify event should be called with updated number_of_hd_entropies and updated number_of_account_groups
8. Connect a Ledger wallet and notice the Identify event received logged with updated number_of_account_groups, updated number_of_ledger_accounts and number_of_hardware_wallets
9. repeat the above steps with qr. The respective properties should all be updated.

Screenshots/Recordings

Before

n/A

After

1. create a fresh wallet with one account

{
    "type": "identify",
    "userId": "d372edfb-19ee-4664-86f6-6418bbd4a1bb",
    "traits": {
        "number_of_hd_entropies": 1,
        "number_of_account_groups": 1,
        "number_of_imported_accounts": 0,
        "number_of_ledger_accounts": 0,
        "number_of_qr_hardware_accounts": 0,
        "number_of_hardware_wallets": 0
    }
}

2. adding a new HD account

{
    "number_of_hd_entropies": 1,
    "number_of_account_groups": 2,
    "number_of_imported_accounts": 0,
    "number_of_ledger_accounts": 0,
    "number_of_qr_hardware_accounts": 0,
    "number_of_hardware_wallets": 0
}

3. import a private key account

{
    "number_of_hd_entropies": 1,
    "number_of_account_groups": 3,
    "number_of_imported_accounts": 1,
    "number_of_ledger_accounts": 0,
    "number_of_qr_hardware_accounts": 0,
    "number_of_hardware_wallets": 0
}

4. import a Ledger account with 3 accounts

{
    "number_of_hd_entropies": 1,
    "number_of_account_groups": 6,
    "number_of_imported_accounts": 1,
    "number_of_ledger_accounts": 3,
    "number_of_qr_hardware_accounts": 0,
    "number_of_hardware_wallets": 1
}

5. adding a qr hardware wallet with 3 accounts

{
    "number_of_hd_entropies": 1,
    "number_of_account_groups": 9,
    "number_of_imported_accounts": 1,
    "number_of_ledger_accounts": 3,
    "number_of_qr_hardware_accounts": 3,
    "number_of_hardware_wallets": 2
}

6. import an SRP with 42 accounts accounts

{
    "number_of_hd_entropies": 2,
    "number_of_account_groups": 51,
    "number_of_imported_accounts": 1,
    "number_of_ledger_accounts": 3,
    "number_of_qr_hardware_accounts": 3,
    "number_of_hardware_wallets": 2
}

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Changes analytics identify behavior and the trait schema (new required fields and new identify triggers on account state changes), which could impact event volume/quality if fingerprinting or account classification is wrong.

Overview
Updates Segment user-profile metrics to be AccountsController-driven wallet composition traits, adding new counts for number_of_account_groups, imported accounts, Ledger/QR hardware accounts, and distinct hardware wallet device types, and making number_of_hd_entropies mandatory and entropy-aware (BIP-44 multichain dedupe via entropy.id:groupIndex).

Moves trait emission out of the Wallet view by removing the addTraitsToUser effect and instead wiring analytics-controller-init to subscribe to AccountsController:stateChange, recomputing traits only when a stable composition fingerprint changes (with error logging), plus adds a dedicated init messenger and comprehensive unit tests for the new fingerprinting and trait counting logic.

^{Reviewed by Cursor Bugbot for commit 3b13d21. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[hmalik88]

If the try fails, don't we need to re-assign this to it's previous value?

[owencraston]

Good point, I adjusted the logic for this case.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 6c3e9e2. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeWalletPlatform, SmokeAccounts, SmokeIdentity
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 82%

click to see 🤖 AI reasoning details

E2E Test Selection:

The changes refactor analytics trait tracking from the React component layer (Wallet view) to the Engine controller layer (AnalyticsController init). Key changes:

1. analytics-controller-init.ts: Adds a subscription to AccountsController:stateChange that calls analytics.identify() with account composition traits (HD entropies, account groups, imported/ledger/QR hardware accounts). Uses fingerprint-based deduplication to avoid redundant calls.

2. analytics-controller-messenger.ts: New AnalyticsControllerInitMessenger scoped to AccountsController:stateChange events.

3. messengers/index.ts: Wires up the new init messenger instead of noop.

4. Wallet/index.tsx: Removes the useEffect that called addTraitsToUser({NUMBER_OF_HD_ENTROPIES: hdKeyrings.length}) - this logic is now in the controller layer.

5. generateUserProfileAnalyticsMetaData.ts: New getAccountCompositionTraits() function computing 6 new wallet composition traits from internalAccounts.

6. UserProfileAnalyticsMetaData.types.ts: 5 new UserProfileProperty enum values added.

Test selection rationale:

• SmokeWalletPlatform: Tests wallet lifecycle analytics tracking for new wallet creation and SRP import events. The changes directly affect how analytics identify calls are made during wallet lifecycle events. Also covers multi-SRP architecture which exercises the new account composition tracking.
• SmokeAccounts: Tests multi-account workflows including creating HD wallet accounts, importing accounts via private key, QR hardware wallet accounts - all of which would trigger the new AccountsController:stateChange subscription and the new composition traits.
• SmokeIdentity: Tests multi-SRP account synchronization and account discovery - directly exercises the account composition tracking logic (HD entropy IDs, account groups).

No performance tests needed: The changes are analytics-only (identify calls), not UI rendering or data loading performance. The fingerprint deduplication ensures minimal overhead.

No other tags needed: The changes don't affect transaction flows (SmokeConfirmations), swap/bridge (SmokeTrade), network management (SmokeNetworkAbstractions/Expansion), browser (SmokeBrowser), snaps (SmokeSnaps), ramps (SmokeRamps), or other feature areas.

Performance Test Selection:
The changes are purely analytics-related (moving identify() calls from React component to controller layer). No UI rendering, list performance, data loading, or app startup changes are involved. The fingerprint deduplication in the new subscription minimizes any overhead. No performance tests are warranted.

View GitHub Actions results

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud