chore: test design-tokens preview build of pure black [DO NOT MERGE]#28576
chore: test design-tokens preview build of pure black [DO NOT MERGE]#28576georgewrmarshall wants to merge 4 commits intomainfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
10fdc2c to
8a5305d
Compare
| @@ -1,9 +1,9 @@ | |||
| // Third party dependencies. | |||
| // eslint-disable-next-line @typescript-eslint/no-shadow | |||
| import { Platform, StyleSheet, ViewStyle } from 'react-native'; | |||
There was a problem hiding this comment.
Moved to this PR can be merged before this #28609
| @@ -2,7 +2,7 @@ | |||
| import { StyleSheet } from 'react-native'; | |||
There was a problem hiding this comment.
Moved to this PR can be merged before this #28609
8a5305d to
04580c0
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Caution MetaMask internal reviewing guidelines:
|
dc5aaf6 to
b16bb23
Compare
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Given the BottomSheet and design system changes affect virtually every user flow, all tags are warranted. The BottomSheet background change alone could cause visual regressions in confirmations, account selection, network selection, snaps dialogs, and more. Performance Test Selection: |



Description
Updates the `@metamask/design-tokens` dependency to a preview build for testing purposes. This allows us to validate the changes in MetaMask/metamask-design-system#1045 before they are officially released.
Change: `@metamask/design-tokens ^8.3.0` → `npm:@metamask-previews/design-tokens@8.3.0-preview.dbe1fac`
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
```gherkin
Feature: design tokens preview testing
Scenario: user validates design token changes from upstream PR
Given the app is built with the preview design-tokens package
When user navigates through affected UI surfaces
Then the design token changes from MetaMask/metamask-design-system#1045 appear as expected
```
Screenshots/Recordings
Before
design-tokens.pure.black.before720.mov
After
after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Primarily a dependency/resolution bump to preview
@metamaskdesign-system packages, which can cause broad UI/theme regressions across the app despite minimal app-code changes.Overview
Switches the app to consume preview MetaMask design system artifacts (notably
@metamask/design-tokens) for upstream “pure black” theme validation.Adds/updates a Yarn patch for the preview
@metamask-previews/design-system-react-nativepackage so its compiled imports resolve against the non-preview@metamask/design-system-sharedand@metamask/design-system-twrnc-presetpackages, avoiding mixed preview namespace imports at runtime.Reviewed by Cursor Bugbot for commit b16bb23. Bugbot is set up for automated code reviews on this repo. Configure here.