chore: TPSL classification by gambinish · Pull Request #41971 · MetaMask/metamask-extension

gambinish · 2026-04-20T17:10:47Z

Description

perps order UI was not treating TP/SL correctly for short vs long positions.

Centralized TP/SL–related order logic in orderUtils (with unit tests) and wired the perps order card to use it.
Trimmed duplicate logic out of transactionTransforms.

Changelog

CHANGELOG entry: Classify TP/SL orders

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-2905

Manual testing steps

Open a market order. Modify tpsl for that market order. TPSL orders should appear within the market detail page. TPSL orders should not appear within the main perps tab (aligns with mobile experience)

Screenshots/Recordings

Screen.Recording.2026-04-21.at.9.01.41.AM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes how TP/SL (trigger) orders are labeled, valued, and filtered between the Perps tab and market detail pages; mistakes could hide orders or show incorrect prices. Logic is centralized and covered by new unit/UI tests, reducing regression risk.

Overview
Unifies TP/SL (trigger) order classification and display across the Perps UI. Open Orders on the main Perps tab now explicitly filter out TP/SL rows (isTrigger and isPositionTpsl), leaving TP/SL visibility to the per-market detail page.

Updates order labeling and pricing for trigger-based orders. OrderCard now uses a shared formatOrderLabel utility, shows trigger price (not size×price notional) for TP/SL, adds a Trigger price subtitle, and tweaks layout to allow multi-line TP/SL labels.

Centralizes order-label logic and adjusts market-detail order visibility. formatOrderLabel is added to orderUtils (and removed from transactionTransforms), and market detail normalization now includes full-position TP/SL orders rather than filtering them out; extensive new tests cover label formatting, TP/SL rendering, and filtering behavior.

^{Reviewed by Cursor Bugbot for commit fbbde7b. Bugbot is set up for automated code reviews on this repo. Configure here.}

metamaskbotv2 · 2026-04-20T17:11:35Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/perps (9 files, +389 -137)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 perps/
      - 📁 order-card/
        
        📄 order-card.test.tsx +125 -17
        
        📄 order-card.tsx +55 -22
      - 📁 utils/
        
        📄 index.ts +1 -0
        
        📄 orderUtils.test.ts +137 -28
        
        📄 orderUtils.ts +50 -14
        
        📄 transactionTransforms.ts +1 -47
        
        📄 perps-view.test.tsx +9 -0
        
        📄 perps-view.tsx +9 -7
- 📁 pages/
  - 📁 perps/
    - 📄 perps-market-detail-page.tsx +2 -2

metamaskbotv2 · 2026-04-20T17:38:02Z

Builds ready [41f7815]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24679937667 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -75%
↓ loadNewAccount/total: -75%
↓ bridgeUserActions/bridge_load_page: -34%
↓ bridgeUserActions/bridge_load_asset_picker: -47%
↓ bridgeUserActions/bridge_search_token: -33%
↓ bridgeUserActions/total: -36%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.8s
🟡 confirmTx/FCP: p75 2.2s
🟡 bridgeUserActions/FCP: p75 2.1s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/uiStartup: -23%
↓ startupStandardHome/load: -11%
↓ startupStandardHome/domContentLoaded: -14%
↑ startupStandardHome/domInteractive: +12%
↓ startupStandardHome/initialActions: -33%
↓ startupStandardHome/loadScripts: -17%
↑ startupStandardHome/setupStore: +14%
↓ startupStandardHome/numNetworkReqs: -37%
↓ startupStandardHome/uiStartup: -20%
↓ startupStandardHome/load: -15%
↓ startupStandardHome/domContentLoaded: -15%
↓ startupStandardHome/firstPaint: -17%
↓ startupStandardHome/backgroundConnect: -36%
↓ startupStandardHome/firstReactRender: -23%
↓ startupStandardHome/loadScripts: -15%
↓ startupStandardHome/setupStore: -13%
↓ startupStandardHome/numNetworkReqs: -44%
↓ startupStandardHome/domInteractive: -17%
↑ startupStandardHome/backgroundConnect: +17%
↑ startupStandardHome/initialActions: +33%
↓ startupStandardHome/numNetworkReqs: -34%
↓ startupStandardHome/uiStartup: -34%
↓ startupStandardHome/load: -27%
↓ startupStandardHome/domContentLoaded: -28%
↓ startupStandardHome/domInteractive: -51%
↓ startupStandardHome/backgroundConnect: -26%
↓ startupStandardHome/firstReactRender: -23%
↓ startupStandardHome/initialActions: -43%
↓ startupStandardHome/loadScripts: -28%
↓ startupStandardHome/setupStore: -70%
↓ startupStandardHome/numNetworkReqs: -34%

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -88%
↓ onboardingImportWallet/confirmSrpToPwForm: -27%
↓ onboardingImportWallet/pwFormToMetricsScreen: -25%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -55%
↓ onboardingImportWallet/doneButtonToHomeScreen: -88%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +35%
↓ onboardingImportWallet/total: -52%
↓ onboardingNewWallet/srpButtonToPwForm: -78%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -68%
↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +19%
↓ onboardingNewWallet/doneButtonToAssetList: -25%
↓ onboardingNewWallet/total: -26%
↓ assetDetails/assetClickToPriceChart: -41%
↓ assetDetails/total: -41%
↓ solanaAssetDetails/assetClickToPriceChart: -80%
↓ solanaAssetDetails/total: -80%
↓ importSrpHome/openAccountMenuAfterLogin: -65%
↓ importSrpHome/homeAfterImportWithNewWallet: -67%
↓ importSrpHome/total: -60%
↑ sendTransactions/selectTokenToSendFormLoaded: +38%
↑ sendTransactions/reviewTransactionToConfirmationPage: +37%
↑ sendTransactions/total: +36%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +32%
↑ swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/FCP: p75 2.7s
🟡 assetDetails/LCP: p75 2.6s
🟡 solanaAssetDetails/FCP: p75 2.7s
🟡 importSrpHome/FCP: p75 2.6s
🟡 importSrpHome/LCP: p75 2.5s
🟡 sendTransactions/FCP: p75 2.5s
🟡 swap/FCP: p75 2.6s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.82 KiB (0.05%)
ui: 39 Bytes (0%)
common: 39 Bytes (0%)

metamaskbotv2 · 2026-04-20T23:32:27Z

Builds ready [f98c138]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24695087094 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -74%
↓ loadNewAccount/total: -74%
↓ bridgeUserActions/bridge_load_page: -26%
↓ bridgeUserActions/bridge_load_asset_picker: -33%
↓ bridgeUserActions/bridge_search_token: -21%
↓ bridgeUserActions/total: -29%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.5s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/uiStartup: -29%
↓ startupStandardHome/load: -18%
↓ startupStandardHome/domContentLoaded: -20%
↓ startupStandardHome/firstReactRender: -14%
↓ startupStandardHome/initialActions: -33%
↓ startupStandardHome/loadScripts: -23%
↓ startupStandardHome/numNetworkReqs: -37%
↓ startupStandardHome/uiStartup: -21%
↓ startupStandardHome/load: -16%
↓ startupStandardHome/domContentLoaded: -16%
↓ startupStandardHome/firstPaint: -25%
↓ startupStandardHome/backgroundConnect: -36%
↓ startupStandardHome/firstReactRender: -23%
↓ startupStandardHome/loadScripts: -16%
↓ startupStandardHome/setupStore: -13%
↓ startupStandardHome/numNetworkReqs: -44%
↓ startupStandardHome/uiStartup: -13%
↓ startupStandardHome/domInteractive: -48%
↑ startupStandardHome/backgroundConnect: +11%
↓ startupStandardHome/initialActions: -33%
↓ startupStandardHome/numNetworkReqs: -34%
↓ startupStandardHome/uiStartup: -18%
↓ startupStandardHome/domInteractive: -49%
↓ startupStandardHome/backgroundConnect: -11%
↓ startupStandardHome/initialActions: -43%
↓ startupStandardHome/setupStore: -60%
↓ startupStandardHome/numNetworkReqs: -32%

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -88%
↓ onboardingImportWallet/confirmSrpToPwForm: -25%
↓ onboardingImportWallet/pwFormToMetricsScreen: -19%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -57%
↓ onboardingImportWallet/doneButtonToHomeScreen: -76%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +15%
↓ onboardingImportWallet/total: -46%
↓ onboardingNewWallet/srpButtonToPwForm: -76%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -66%
↓ onboardingNewWallet/doneButtonToAssetList: -22%
↓ onboardingNewWallet/total: -24%
↓ assetDetails/assetClickToPriceChart: -47%
↓ assetDetails/total: -47%
↓ solanaAssetDetails/assetClickToPriceChart: -72%
↓ solanaAssetDetails/total: -72%
↓ importSrpHome/openAccountMenuAfterLogin: -78%
↓ importSrpHome/homeAfterImportWithNewWallet: -68%
↓ importSrpHome/total: -61%
↓ sendTransactions/selectTokenToSendFormLoaded: -32%
↑ sendTransactions/reviewTransactionToConfirmationPage: +38%
↑ sendTransactions/total: +35%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/FCP: p75 2.6s
🟡 assetDetails/LCP: p75 2.6s
🟡 solanaAssetDetails/FCP: p75 2.6s
🟡 importSrpHome/FCP: p75 2.5s
🟡 sendTransactions/INP: p75 248ms
🟡 sendTransactions/FCP: p75 2.5s
🟡 swap/FCP: p75 2.5s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -182.99 KiB (-2.97%)
ui: 34 KiB (0.4%)
common: 3.62 KiB (0.03%)

metamaskbotv2 · 2026-04-21T15:54:19Z

Builds ready [9bd6800]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24731031151 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -70%
↓ loadNewAccount/total: -70%
↓ bridgeUserActions/bridge_load_page: -17%
↓ bridgeUserActions/bridge_load_asset_picker: -32%
↓ bridgeUserActions/bridge_search_token: -27%
↓ bridgeUserActions/total: -27%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.5s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.4s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/uiStartup: -27%
↓ startupStandardHome/load: -16%
↓ startupStandardHome/domContentLoaded: -18%
↓ startupStandardHome/firstReactRender: -14%
↓ startupStandardHome/initialActions: -33%
↓ startupStandardHome/loadScripts: -21%
↓ startupStandardHome/numNetworkReqs: -37%
↓ startupStandardHome/uiStartup: -13%
↑ startupStandardHome/domInteractive: +24%
↑ startupStandardHome/firstPaint: +32%
↓ startupStandardHome/backgroundConnect: -30%
↓ startupStandardHome/firstReactRender: -12%
↓ startupStandardHome/numNetworkReqs: -44%
↓ startupStandardHome/uiStartup: -16%
↓ startupStandardHome/domInteractive: -63%
↓ startupStandardHome/initialActions: -33%
↓ startupStandardHome/setupStore: -25%
↓ startupStandardHome/numNetworkReqs: -34%
↓ startupStandardHome/uiStartup: -14%
↓ startupStandardHome/domInteractive: -46%
↑ startupStandardHome/initialActions: +14%
↓ startupStandardHome/setupStore: -47%
↓ startupStandardHome/numNetworkReqs: -32%

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -84%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -30%
↓ onboardingImportWallet/doneButtonToHomeScreen: -76%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +26%
↓ onboardingImportWallet/total: -45%
↓ onboardingNewWallet/srpButtonToPwForm: -79%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -68%
↓ onboardingNewWallet/doneButtonToAssetList: -27%
↓ onboardingNewWallet/total: -28%
↓ assetDetails/assetClickToPriceChart: -61%
↓ assetDetails/total: -61%
↓ solanaAssetDetails/assetClickToPriceChart: -65%
↓ solanaAssetDetails/total: -65%
↓ importSrpHome/loginToHomeScreen: -16%
↓ importSrpHome/openAccountMenuAfterLogin: -72%
↓ importSrpHome/homeAfterImportWithNewWallet: -67%
↓ importSrpHome/total: -60%
↓ sendTransactions/openSendPageFromHome: -13%
↓ sendTransactions/selectTokenToSendFormLoaded: -12%
↑ sendTransactions/reviewTransactionToConfirmationPage: +36%
↑ sendTransactions/total: +34%
↓ swap/openSwapPageFromHome: -97%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/FCP: p75 2.4s
🟡 solanaAssetDetails/FCP: p75 2.4s
🟡 importSrpHome/FCP: p75 3.0s
🟡 sendTransactions/FCP: p75 2.5s
🟡 swap/FCP: p75 2.5s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -182.96 KiB (-2.97%)
ui: 33.27 KiB (0.39%)
common: 3.4 KiB (0.03%)

sonarqubecloud · 2026-04-21T18:03:47Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-04-21T18:13:34Z

Builds ready [fbbde7b]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24737747031 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -72%
↓ loadNewAccount/total: -72%
↓ bridgeUserActions/bridge_load_page: -22%
↓ bridgeUserActions/bridge_load_asset_picker: -28%
↓ bridgeUserActions/bridge_search_token: -26%
↓ bridgeUserActions/total: -27%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.5s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/uiStartup: -27%
↓ startupStandardHome/load: -16%
↓ startupStandardHome/domContentLoaded: -18%
↓ startupStandardHome/firstReactRender: -18%
↓ startupStandardHome/initialActions: -33%
↓ startupStandardHome/loadScripts: -22%
↓ startupStandardHome/numNetworkReqs: -37%
↓ startupStandardHome/uiStartup: -21%
↓ startupStandardHome/load: -17%
↓ startupStandardHome/domContentLoaded: -16%
↓ startupStandardHome/backgroundConnect: -37%
↓ startupStandardHome/firstReactRender: -27%
↓ startupStandardHome/loadScripts: -16%
↓ startupStandardHome/setupStore: -13%
↓ startupStandardHome/numNetworkReqs: -44%
↓ startupStandardHome/uiStartup: -12%
↓ startupStandardHome/domInteractive: -57%
↑ startupStandardHome/initialActions: +33%
↓ startupStandardHome/numNetworkReqs: -34%
↓ startupStandardHome/domInteractive: -34%
↑ startupStandardHome/initialActions: +14%
↓ startupStandardHome/setupStore: -54%
↓ startupStandardHome/numNetworkReqs: -34%

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -84%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -37%
↓ onboardingImportWallet/doneButtonToHomeScreen: -77%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +18%
↓ onboardingImportWallet/total: -46%
↓ onboardingNewWallet/srpButtonToPwForm: -78%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -69%
↓ onboardingNewWallet/doneButtonToAssetList: -38%
↓ onboardingNewWallet/total: -37%
↓ assetDetails/assetClickToPriceChart: -15%
↓ assetDetails/total: -15%
↓ solanaAssetDetails/assetClickToPriceChart: -77%
↓ solanaAssetDetails/total: -77%
↓ importSrpHome/openAccountMenuAfterLogin: -68%
↓ importSrpHome/homeAfterImportWithNewWallet: -68%
↓ importSrpHome/total: -61%
↓ sendTransactions/openSendPageFromHome: -30%
↓ sendTransactions/selectTokenToSendFormLoaded: -12%
↑ sendTransactions/reviewTransactionToConfirmationPage: +36%
↑ sendTransactions/total: +34%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +32%
↑ swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/INP: p75 208ms
🟡 assetDetails/FCP: p75 2.5s
🟡 solanaAssetDetails/FCP: p75 2.5s
🟡 importSrpHome/FCP: p75 2.6s
🟡 sendTransactions/FCP: p75 2.5s
🟡 swap/FCP: p75 2.5s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -182.96 KiB (-2.97%)
ui: 34.29 KiB (0.4%)
common: 3.46 KiB (0.03%)

chore: TPSL clasification

41f7815

gambinish temporarily deployed to pr-comment April 20, 2026 17:10 — with GitHub Actions Inactive

metamaskbot added the team-perps Perps team label Apr 20, 2026

github-actions Bot added the size-M label Apr 20, 2026

gambinish temporarily deployed to pr-comment April 20, 2026 17:33 — with GitHub Actions Inactive

gambinish changed the title ~~chore: TPSL clasification~~ chore: TPSL classification Apr 20, 2026

chore: Add tpsl orders on perps tab and detail view

f98c138

gambinish temporarily deployed to pr-comment April 20, 2026 23:11 — with GitHub Actions Inactive

gambinish temporarily deployed to pr-comment April 20, 2026 23:30 — with GitHub Actions Inactive

fix: filter tpsl orders on perps tab

9bd6800

gambinish temporarily deployed to pr-comment April 21, 2026 15:26 — with GitHub Actions Inactive

gambinish temporarily deployed to pr-comment April 21, 2026 15:52 — with GitHub Actions Inactive

gambinish marked this pull request as ready for review April 21, 2026 16:03

gambinish requested a review from a team as a code owner April 21, 2026 16:04

gambinish temporarily deployed to pr-comment April 21, 2026 16:04 — with GitHub Actions Inactive

chore: update text and alignment

fbbde7b

gambinish temporarily deployed to pr-comment April 21, 2026 17:50 — with GitHub Actions Inactive

github-actions Bot added size-L and removed size-M labels Apr 21, 2026

gambinish temporarily deployed to pr-comment April 21, 2026 18:10 — with GitHub Actions Inactive

michalconsensys approved these changes Apr 21, 2026

View reviewed changes

aganglada approved these changes Apr 21, 2026

View reviewed changes

aganglada enabled auto-merge April 21, 2026 18:13

aganglada added this pull request to the merge queue Apr 21, 2026

Merged via the queue into main with commit b4dce0a Apr 21, 2026
210 checks passed

aganglada deleted the perps/tat-2905-tpsl-order-short-long branch April 21, 2026 18:53

github-actions Bot locked and limited conversation to collaborators Apr 21, 2026

metamaskbot added the release-13.29.0 Issue or pull request that will be included in release 13.29.0 label Apr 21, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: TPSL classification#41971

chore: TPSL classification#41971
aganglada merged 4 commits intomainfrom
perps/tat-2905-tpsl-order-short-long

gambinish commented Apr 20, 2026 •

edited by cursor Bot

Loading

Uh oh!

metamaskbotv2 Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 Bot commented Apr 20, 2026

Uh oh!

metamaskbotv2 Bot commented Apr 20, 2026

Uh oh!

metamaskbotv2 Bot commented Apr 21, 2026

Uh oh!

sonarqubecloud Bot commented Apr 21, 2026

Uh oh!

metamaskbotv2 Bot commented Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gambinish commented Apr 20, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 Bot commented Apr 20, 2026

Uh oh!

metamaskbotv2 Bot commented Apr 20, 2026

Uh oh!

metamaskbotv2 Bot commented Apr 21, 2026

Uh oh!

sonarqubecloud Bot commented Apr 21, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 Bot commented Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gambinish commented Apr 20, 2026 •

edited by cursor Bot

Loading

metamaskbotv2 Bot commented Apr 20, 2026 •

edited

Loading