Skip to content

release(runway): cherry-pick fix(perps): percent issue on markets page cp-13.28.0 #41969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chloeYue merged 1 commit into from
Apr 20, 2026
+10 −2
Merged

release(runway): cherry-pick fix(perps): percent issue on markets page cp-13.28.0 #41969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ui/pages/perps/market-list/components/market-row/market-row.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ describe('MarketRow', () => {
expect(screen.getByText('+2.5%')).toBeInTheDocument();
});

it('appends % to change24hPercent when stream omits it', () => {
const market = createMockMarket({ change24hPercent: '+2.5' });
renderWithProvider(<MarketRow market={market} />, mockStore);

expect(screen.getByText('+2.5%')).toBeInTheDocument();
});

it('displays the max leverage', () => {
renderWithProvider(<MarketRow {...defaultProps} />, mockStore);

Expand Down
5 changes: 3 additions & 2 deletions ui/pages/perps/market-list/components/market-row/market-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { PerpsTokenLogo } from '../../../../../components/app/perps/perps-token-
import {
getDisplaySymbol,
getChangeColor,
formatSignedChangePercent,
} from '../../../../../components/app/perps/utils';
import { useFormatters } from '../../../../../hooks/useFormatters';
import type { PerpsMarketData } from '../../../../../components/app/perps/types';
Expand Down Expand Up @@ -44,7 +45,7 @@ const getMetricValue = (
case 'volume':
return `${market.volume} Vol`;
case 'priceChange':
return market.change24hPercent;
return formatSignedChangePercent(market.change24hPercent);
case 'fundingRate':
if (market.fundingRate === undefined) {
return 'N/A';
Expand Down Expand Up @@ -153,7 +154,7 @@ export const MarketRow: React.FC<MarketRowProps> = ({
{market.price}
</Text>
<Text variant={TextVariant.BodySm} color={changeColor}>
{market.change24hPercent}
{formatSignedChangePercent(market.change24hPercent)}
</Text>
</Box>
</Box>
Expand Down
Loading