fix: handle missing nonce cases in tx notif and history for 7702 cp-13.29.0#41967
fix: handle missing nonce cases in tx notif and history for 7702 cp-13.29.0#41967
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
f1cc164 to
591fe80
Compare
591fe80 to
7e92470
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7e92470. Configure here.
7e92470 to
b9369e0
Compare
Builds ready [b9369e0]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
b9369e0 to
4a62e74
Compare
4a62e74 to
230a9e5
Compare
|
Builds ready [230a9e5]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|






Description
On Tempo - but also for all transactions using EIP-7702 on other chains - no nonce is stored in the transaction metadata, causing UI glitches in various places:
This PR solves both of those issues, for Tempo and other chains leveraging EIP-7702 (gasless).
Changelog
CHANGELOG entry: remove the
nonceline from tx activity popin when nonce is missing.CHANGELOG entry: remove the nonce from tx success/failure messages when nonce is missing.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/NEB-928?atlOrigin=eyJpIjoiOTIxMjA2ZDUzMjQwNGY1ZWJmNDRlNjJmNmQ0NGU3MjIiLCJwIjoiaiJ9
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: changes only adjust user-facing notification/transaction breakdown messaging when
nonceis missing, with added test coverage and no impact to signing, state, or network logic.Overview
Prevents
NaN/empty nonce display for nonce-less (e.g. EIP-7702) transactions.Extension transaction success/failure notifications now switch to new i18n strings when
txParams.nonceis absent, and the transaction breakdown UI hides the nonce row entirely in that case. Tests were expanded to cover both nonce-present and nonce-missing scenarios.Reviewed by Cursor Bugbot for commit 230a9e5. Bugbot is set up for automated code reviews on this repo. Configure here.