Skip to content

chore: remove legacy settings search and move info tab component#41960

Merged
ameliejyc merged 5 commits intomainfrom
CEUX-996-clean-up-settings-v-1-files-3
Apr 21, 2026
Merged

chore: remove legacy settings search and move info tab component#41960
ameliejyc merged 5 commits intomainfrom
CEUX-996-clean-up-settings-v-1-files-3

Conversation

@ameliejyc
Copy link
Copy Markdown
Contributor

@ameliejyc ameliejyc commented Apr 20, 2026

Description

Moves and renames the Info component used in the Settings > About tab
Deletes the unused settings search and settings search list components

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Check that the About tab still shows the correct info

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Primarily deletes unused UI code and renames/moves the About tab component; behavior changes should be limited to settings navigation and About rendering.

Overview
Removes the legacy Settings search components (settings-search and settings-search-list) and drops the related i18n strings (missingSetting, missingSettingRequest) across locales.

Moves/renames the Settings > About content from the old InfoTab to a new settings-v2 AboutInfo component, updates the About tab to render it, and adjusts the unit test/baseline to match the rename and updated warning expectations.

Reviewed by Cursor Bugbot for commit b5d21ba. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Apr 20, 2026
@ameliejyc ameliejyc marked this pull request as ready for review April 20, 2026 15:24
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 Bot commented Apr 20, 2026

Builds ready [af3c2d4] [reused from 3b219d2]
⚡ Performance Benchmarks (Total: 🟢 2 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24674961411 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-browserify
loadNewAccount🟡 [Show logs]
confirmTx🟡 [Show logs]
bridgeUserActions🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -73%
  • loadNewAccount/total: -73%
  • bridgeUserActions/bridge_load_page: -19%
  • bridgeUserActions/bridge_load_asset_picker: -29%
  • bridgeUserActions/bridge_search_token: -24%
  • bridgeUserActions/total: -28%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.5s
  • 🟡 confirmTx/FCP: p75 2.4s
  • 🟡 bridgeUserActions/FCP: p75 2.5s
Startup Benchmarks · Samples: 100

⚠️ Missing data: chrome/browserify/startupStandardHome, chrome/webpack/startupStandardHome, firefox/browserify/startupStandardHome, firefox/webpack/startupStandardHome

✅ No regressions detected

User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-browserify
onboardingImportWallet🟢 [Show logs]
onboardingNewWallet🟢 [Show logs]
assetDetails🟡 [Show logs]
solanaAssetDetails🟡 [Show logs]
importSrpHome🟡 [Show logs]
sendTransactions🟡 [Show logs]
swap🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: -85%
  • onboardingImportWallet/metricsToWalletReadyScreen: -38%
  • onboardingImportWallet/doneButtonToHomeScreen: -77%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: +27%
  • onboardingImportWallet/total: -44%
  • onboardingNewWallet/srpButtonToPwForm: -77%
  • onboardingNewWallet/skipBackupToMetricsScreen: -67%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +27%
  • onboardingNewWallet/doneButtonToAssetList: -28%
  • onboardingNewWallet/total: -29%
  • assetDetails/assetClickToPriceChart: -54%
  • assetDetails/total: -54%
  • solanaAssetDetails/assetClickToPriceChart: -74%
  • solanaAssetDetails/total: -74%
  • importSrpHome/loginToHomeScreen: -14%
  • importSrpHome/openAccountMenuAfterLogin: -69%
  • importSrpHome/homeAfterImportWithNewWallet: -68%
  • importSrpHome/total: -61%
  • sendTransactions/openSendPageFromHome: -20%
  • sendTransactions/selectTokenToSendFormLoaded: -13%
  • sendTransactions/reviewTransactionToConfirmationPage: +37%
  • sendTransactions/total: +36%
  • swap/openSwapPageFromHome: -96%
  • swap/fetchAndDisplaySwapQuotes: +31%
  • swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 2.6s
  • 🟡 solanaAssetDetails/FCP: p75 2.5s
  • 🟡 importSrpHome/FCP: p75 2.5s
  • 🟡 sendTransactions/FCP: p75 2.5s
  • 🟡 swap/FCP: p75 2.5s
Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/browserify/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -63 Bytes (0%)
  • common: -76 Bytes (0%)

@ameliejyc ameliejyc enabled auto-merge April 20, 2026 16:59
AndyMBridges
AndyMBridges previously approved these changes Apr 21, 2026
NidhiKJha
NidhiKJha previously approved these changes Apr 21, 2026
@sonarqubecloud
Copy link
Copy Markdown

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 Bot commented Apr 21, 2026

Builds ready [b5d21ba]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 7 warn · 🔴 1 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24718576221 | Baseline logs

Metricschrome-browserifychrome-webpackfirefox-browserifyfirefox-webpack
assetDetails🔴 [logs]

Regressions (🔴 1 failure)

  • assetDetails · chrome-browserify — cls(p75) [Show logs]
Interaction Benchmarks · Samples: 5
Benchmarkchrome-browserify
loadNewAccount🟡 [Show logs]
confirmTx🟡 [Show logs]
bridgeUserActions🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -67%
  • loadNewAccount/total: -67%
  • bridgeUserActions/bridge_load_page: -17%
  • bridgeUserActions/bridge_load_asset_picker: -17%
  • bridgeUserActions/bridge_search_token: -28%
  • bridgeUserActions/total: -27%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.6s
  • 🟡 confirmTx/FCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-browserifychrome-webpackfirefox-browserifyfirefox-webpack
startupStandardHome🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/uiStartup: -21%
  • startupStandardHome/domContentLoaded: -12%
  • startupStandardHome/firstReactRender: -14%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/loadScripts: -14%
  • startupStandardHome/numNetworkReqs: -37%
  • startupStandardHome/uiStartup: -20%
  • startupStandardHome/load: -16%
  • startupStandardHome/domContentLoaded: -15%
  • startupStandardHome/domInteractive: +11%
  • startupStandardHome/backgroundConnect: -38%
  • startupStandardHome/firstReactRender: -23%
  • startupStandardHome/loadScripts: -15%
  • startupStandardHome/setupStore: -13%
  • startupStandardHome/numNetworkReqs: -44%
  • startupStandardHome/domInteractive: -20%
  • startupStandardHome/backgroundConnect: +14%
  • startupStandardHome/initialActions: +33%
  • startupStandardHome/numNetworkReqs: -32%
  • startupStandardHome/uiStartup: -15%
  • startupStandardHome/domInteractive: -51%
  • startupStandardHome/initialActions: -43%
  • startupStandardHome/setupStore: -50%
  • startupStandardHome/numNetworkReqs: -32%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-browserify
onboardingImportWallet🟢 [Show logs]
onboardingNewWallet🟢 [Show logs]
assetDetails🔴 [Show logs] · 🔴 cls
solanaAssetDetails🟡 [Show logs]
importSrpHome🟡 [Show logs]
sendTransactions🟡 [Show logs]
swap🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: -84%
  • onboardingImportWallet/metricsToWalletReadyScreen: -31%
  • onboardingImportWallet/doneButtonToHomeScreen: -77%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: +26%
  • onboardingImportWallet/total: -44%
  • onboardingNewWallet/srpButtonToPwForm: -78%
  • onboardingNewWallet/skipBackupToMetricsScreen: -65%
  • onboardingNewWallet/doneButtonToAssetList: -31%
  • onboardingNewWallet/total: -32%
  • assetDetails/assetClickToPriceChart: -50%
  • assetDetails/total: -50%
  • solanaAssetDetails/assetClickToPriceChart: -64%
  • solanaAssetDetails/total: -64%
  • importSrpHome/loginToHomeScreen: -11%
  • importSrpHome/openAccountMenuAfterLogin: -62%
  • importSrpHome/homeAfterImportWithNewWallet: -69%
  • importSrpHome/total: -61%
  • sendTransactions/selectTokenToSendFormLoaded: +14%
  • sendTransactions/reviewTransactionToConfirmationPage: +36%
  • sendTransactions/total: +34%
  • swap/openSwapPageFromHome: -96%
  • swap/fetchAndDisplaySwapQuotes: +31%
  • swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 2.4s
  • 🔴 assetDetails/CLS: p75 0.345
  • 🟡 solanaAssetDetails/FCP: p75 2.4s
  • 🟡 importSrpHome/FCP: p75 2.5s
  • 🟡 sendTransactions/FCP: p75 2.5s
  • 🟡 swap/FCP: p75 2.5s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-browserify
dappPageLoad🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/firstPaint: +14%
  • dappPageLoad/firstContentfulPaint: +14%
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -63 Bytes (0%)
  • common: -76 Bytes (0%)

@ameliejyc ameliejyc added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit a3a09ae Apr 21, 2026
209 of 210 checks passed
@ameliejyc ameliejyc deleted the CEUX-996-clean-up-settings-v-1-files-3 branch April 21, 2026 13:38
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2026
@metamaskbot metamaskbot added the release-13.29.0 Issue or pull request that will be included in release 13.29.0 label Apr 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.29.0 Issue or pull request that will be included in release 13.29.0 size-M team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants