-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore(6936): migrate core UI components from MUI v4 → v5 #41955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
25
commits into
main
Choose a base branch
from
copilot/migrate-core-ui-components-mui-v4-v5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e9cfaba
Initial plan
Copilot 415b6eb
feat: migrate core UI components from MUI v4 to v5
Copilot e029c63
Update LavaMoat policies
metamaskbot 9ef13df
Merge remote-tracking branch 'origin/main' into copilot/migrate-core-…
DDDDDanica ef2c0cb
chore: update snapshot and new v5 text-field props
DDDDDanica df9d5dc
Merge remote-tracking branch 'origin/main' into copilot/migrate-core-…
DDDDDanica e43c1b8
Merge remote-tracking branch 'origin/main' into copilot/migrate-core-…
DDDDDanica ac2ee62
chore: update snapshot
DDDDDanica 54c748d
perf: fix Missing variant: 'standard' for material TextField themes
DDDDDanica c6847e4
per: Added the narrowed @emotion/react>@emotion/cache entry to lavamo…
DDDDDanica 68f6efc
per: Added the narrowed @emotion/react>@emotion/cache entry
DDDDDanica 21237a2
per: fix failed policy
DDDDDanica 6a724e4
per: fix failed policy 2
DDDDDanica 941ed5a
Merge branch 'main' into copilot/migrate-core-ui-components-mui-v4-v5
DDDDDanica 4c65e14
Merge branch 'main' into copilot/migrate-core-ui-components-mui-v4-v5
DDDDDanica cd3277c
per: narrow @emotion/react>@emotion/cache document access to prevent …
DDDDDanica 2a03af1
chore: resolve Slider sx overridden by rest-spread ordering and make …
DDDDDanica b2bbe71
chore: migrate Slider to v5
DDDDDanica 60c4725
chore: fix the styles
DDDDDanica 1f0a9c3
chore: fix the styles and policy
DDDDDanica 8c507d0
chore: fix slider unit test and @mui/material policy.
DDDDDanica 1a5cd3a
chore: fix PerpsOrderEntryPage unit test
DDDDDanica b5cfc93
chore: fix lint
DDDDDanica 74bbe28
Merge remote-tracking branch 'origin/copilot/migrate-core-ui-componen…
DDDDDanica 8bf27bc
chore: fix lint and perps e2e
DDDDDanica File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naugtur webpack's policy build has narrowed the
documentusages here down to a reasonable subset, usual just one or two properties ondocument. With webpack aiming to be released in about 1-2 weeks, do you think we should still bother with locking this down in the browserify build today?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a chance it's getting released from a browserify build still, it'd be prudent to do so.
It's a matter of dropping
into the policy-override.json in browserify folder.
I'd keep putting in the work to narrow it down for now in case something goes wrong and we urgently need to fall back to browserify build one last time. Nobody's gonna have the time to worry about the policy differences at that time, so let's keep it off their plates with 2 miuntes of investment if possible.
If we're sure we'll not release browserify builds ever again, it's fine to skip. (but if that was the case we'd have removed the browserify setup already I suppose)