fix: display USD only in MM Pay confirmation screens cp-13.28.0#41953
Conversation
…ess of user currency
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (8 files, +48 -3)
|
Builds ready [b3ddf69]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
Builds ready [c177122]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
Builds ready [d669060]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
|
Builds ready [bdad5f3]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|



Description
When the user's preferred currency is not USD (e.g. EUR, BRL), the MM Pay deposit and mUSD conversion confirmation screens display a mix of currencies — the hero input shows
$while the Transaction fee, Total, and Pay-with balance rows use the user's local currency symbol (€, R$). This is confusing and inconsistent with mobile behavior.This PR forces all fiat displays in these confirmation screens to always render in USD. It adds an
overrideCurrencyoption to theuseFiatFormatterhook and uses it in the three affected row components.Changelog
CHANGELOG entry: Fixed mixed currency symbols on MM Pay, Perps deposit, and mUSD conversion confirmation screens to always display USD
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1133 #42075
Manual testing steps
$, the Transaction fee shows$, the Total shows$, and the Pay-with balance shows$(no€or other symbols)$$Screenshots/Recordings
perps-musd-only-usd.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Small, localized UI formatting change with added test coverage; main risk is minor regressions in fiat formatting call sites that now pass an optional override.
Overview
Fixes mixed fiat symbols on MM Pay-related confirmation screens by forcing USD formatting for key amounts.
Adds an
overrideCurrencyoption touseFiatFormatterand uses it inBridgeFeeRow,TotalRow, andPayWithRowso displayed totals/fees/balances always render as$...regardless of the user’s preferred currency.MusdConversionInfonow passescurrency="usd"intoCustomAmountInfoto keep the hero amount consistently in USD, with tests updated/added to cover these behaviors.Reviewed by Cursor Bugbot for commit bdad5f3. Bugbot is set up for automated code reviews on this repo. Configure here.