Skip to content

fix: address review comments on PR #41949

ce2cb1d
Select commit
Loading
Failed to load commit list.
Merged

feat: Keyboard-first order entry UX: auto-focus, auto-select, Tab navigation & inline validation #41949

fix: address review comments on PR #41949
ce2cb1d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 30, 2026 in 1m 46s

Annotations

Check warning on line 590 in ui/pages/perps/perps-order-entry-page.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`.

See more on https://sonarcloud.io/project/issues?id=metamask-extension&issues=AZ3EYyPyMMAbgOavVPgb&open=AZ3EYyPyMMAbgOavVPgb&pullRequest=41949

Check warning on line 708 in ui/pages/perps/perps-order-entry-page.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis.window` over `window`.

See more on https://sonarcloud.io/project/issues?id=metamask-extension&issues=AZ3SBfRWqgvhdYcr-IQm&open=AZ3SBfRWqgvhdYcr-IQm&pullRequest=41949

Check warning on line 708 in ui/pages/perps/perps-order-entry-page.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`.

See more on https://sonarcloud.io/project/issues?id=metamask-extension&issues=AZ3SBfRWqgvhdYcr-IQn&open=AZ3SBfRWqgvhdYcr-IQn&pullRequest=41949

Check failure on line 248 in app/scripts/lib/metaRPCClientFactory.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=metamask-extension&issues=AZ21uE2ZoJLNjP9hk6AV&open=AZ21uE2ZoJLNjP9hk6AV&pullRequest=41949