Skip to content

fix: Input isn't centered in withdraw flow #41942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HowardBraham merged 7 commits into from
Apr 28, 2026
+61 −21
Merged

fix: Input isn't centered in withdraw flow #41942

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4078a94
fix: Input isn't centered in withdraw flow
abretonc7s Apr 20, 2026
21ac102
fix: center hero amount input in perps withdraw flow
abretonc7s Apr 20, 2026
153f3c2
fix: add w-full to skeleton variant for consistent centering
abretonc7s Apr 20, 2026
02101ad
Merge branch 'main' into fix/tat-2847-center-withdraw-input
abretonc7s Apr 22, 2026
804fa6b
fix: use field-sizing content to center decimal amounts in withdraw i…
abretonc7s Apr 23, 2026
a4dc701
Merge branch 'fix/tat-2847-center-withdraw-input' of github.com:MetaM…
abretonc7s Apr 23, 2026
ed2d3b5
fix: replace field-sizing with cross-browser absolute-overlay pattern
abretonc7s Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions ui/components/app/perps/perps-fiat-hero-amount-input/perps-fiat-hero-amount-input.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ describe('isValidPartialFiatAmountInput', () => {
});

describe('PerpsFiatHeroAmountInput', () => {
it('renders symbol and input for the given value', () => {
render(<PerpsFiatHeroAmountInput value="2.707414" onChange={jest.fn()} />);
expect(
screen.getByTestId('perps-fiat-hero-amount-symbol'),
).toBeInTheDocument();
expect(screen.getByTestId('perps-fiat-hero-amount-input')).toHaveValue(
'2.707414',
);
});

it('renders symbol and forwards input changes', () => {
const onChange = jest.fn();
render(<PerpsFiatHeroAmountInput value="" onChange={onChange} />);
Expand All @@ -46,9 +56,8 @@ describe('PerpsFiatHeroAmountInput', () => {
<PerpsFiatHeroAmountInput value="1" onChange={jest.fn()} isLoading />,
);

expect(
screen.getByTestId('perps-fiat-hero-amount-skeleton'),
).toBeInTheDocument();
const skeleton = screen.getByTestId('perps-fiat-hero-amount-skeleton');
expect(skeleton).toBeInTheDocument();
expect(
screen.queryByTestId('perps-fiat-hero-amount-input'),
).not.toBeInTheDocument();
Expand Down
7 changes: 6 additions & 1 deletion ui/components/app/perps/perps-fiat-hero-amount-input/perps-fiat-hero-amount-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ export const PerpsFiatHeroAmountSkeleton: React.FC = () => (
flexDirection={BoxFlexDirection.Row}
justifyContent={BoxJustifyContent.Center}
alignItems={BoxAlignItems.Center}
className="w-full"
style={{ minHeight: '70px' }}
data-testid="perps-fiat-hero-amount-skeleton"
>
Expand Down Expand Up @@ -134,6 +135,7 @@ export const PerpsFiatHeroAmountInput: React.FC<PerpsFiatHeroAmountInputProps> =
flexDirection={BoxFlexDirection.Row}
justifyContent={BoxJustifyContent.Center}
alignItems={BoxAlignItems.Center}
className="w-full"
Comment thread
abretonc7s marked this conversation as resolved.
style={{ minHeight: '70px' }}
>
<Text
Expand Down Expand Up @@ -162,7 +164,10 @@ export const PerpsFiatHeroAmountInput: React.FC<PerpsFiatHeroAmountInputProps> =
fontSize,
lineHeight,
fontWeight: 500,
width: `${Math.max(1, amountLength)}ch`,
minWidth: '1ch',
// field-sizing: content shrinks/grows the input to its text
// width, keeping the $ + amount pair centred in the flex row.
fieldSizing: 'content',
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
} as React.CSSProperties
}
/>
Expand Down
Loading