Skip to content

fix(perps): Adjust navigation when returning from Perps asset view #41921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aganglada merged 2 commits into from
Apr 22, 2026
Merged

fix(perps): Adjust navigation when returning from Perps asset view #41921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7735e0
fix: Adjust navigation when returning from Perps asset view
abretonc7s Apr 19, 2026
9bb3520
fix: use navigate(-1) for back button on perps market detail page
abretonc7s Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/pages/perps/perps-market-detail-page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,15 +558,15 @@ describe('PerpsMarketDetailPage', () => {
).toBeInTheDocument();
});

it('navigates back when back button is clicked', async () => {
it('navigates back in history when back button is clicked', async () => {
const store = mockStore(createMockState(true));

const { getByTestId } = await renderPage(store);

const backButton = getByTestId('perps-market-detail-back-button');
backButton.click();

expect(mockUseNavigate).toHaveBeenCalledWith('/');
expect(mockUseNavigate).toHaveBeenCalledWith(-1);
});

it('uses market 24h change as fallback when no live percent update exists', async () => {
Expand Down
2 changes: 1 addition & 1 deletion ui/pages/perps/perps-market-detail-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ const PerpsMarketDetailPage: React.FC = () => {
}, []);

const handleBackClick = useCallback(() => {
navigate(DEFAULT_ROUTE);
navigate(-1);
}, [navigate]);

const buildOrderEntryUrl = useCallback(
Expand Down
Loading