chore: Bulk register actions in InstitutionalSnapController#41439
Merged
GuillaumeRx merged 10 commits intomainfrom Apr 8, 2026
Merged
chore: Bulk register actions in InstitutionalSnapController#41439GuillaumeRx merged 10 commits intomainfrom
InstitutionalSnapController#41439GuillaumeRx merged 10 commits intomainfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [6fcb881]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 2 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
GuillaumeRx
force-pushed
the
gr/expose-institutinal-snap-methods-messenger
branch
from
6fcb881 to
2ef0448
Compare
Contributor
Builds ready [2ef0448]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 0 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
GuillaumeRx
force-pushed
the
gr/expose-institutinal-snap-methods-messenger
branch
from
19998e4 to
8bf5301
Compare
Contributor
Builds ready [8bf5301]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
GuillaumeRx
force-pushed
the
gr/expose-institutinal-snap-methods-messenger
branch
from
8bf5301 to
6fd6f27
Compare
GuillaumeRx
commented
Apr 7, 2026
app/scripts/controllers/institutional-snap/InstitutionalSnapController.ts
Show resolved
Hide resolved
cryptodev-2s
reviewed
Apr 7, 2026
Contributor
Builds ready [6fd6f27]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Builds ready [080660b]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
cryptodev-2s
reviewed
Apr 7, 2026
Contributor
cryptodev-2s
left a comment
cryptodev-2s
left a comment
There was a problem hiding this comment.
One small suggestion otherwise; looks good to me!
cryptodev-2s
approved these changes
Apr 7, 2026
Contributor
Builds ready [e965e70]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs
|
… `institutional-snap-controller`
GuillaumeRx
force-pushed
the
gr/expose-institutinal-snap-methods-messenger
branch
from
e965e70 to
492d266
Compare
Contributor
Builds ready [492d266]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs
|
Mrtenz
approved these changes
Apr 8, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
## **Description** This PR updates the `InstitutionalSnapController` to use `registerMethodActionHandlers` and `MESSENGER_EXPOSED_METHODS` to register actions. ## **Changelog** CHANGELOG entry:null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Moderate risk because it changes how messenger actions are registered and renames a public hook method, which could break callers if any still reference the old handler name or types. > > **Overview** > Refactors `InstitutionalSnapController` messenger wiring to use `registerMethodActionHandlers` with an explicit `MESSENGER_EXPOSED_METHODS` list, and renames the hook implementation from `deferPublicationHook` to `publishHook`. > > Introduces an auto-generated `InstitutionalSnapController-method-action-types.ts` and updates controller messenger typings/imports (including `TransactionController` init messenger) to consume these generated action types. Tooling is updated by bumping `@metamask/messenger` and adding `@metamask/messenger-cli`, with new `messenger-action-types` check/generate steps integrated into `lint` and `lint:fix`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 492d266. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.27.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
InstitutionalSnapControllerto useregisterMethodActionHandlersandMESSENGER_EXPOSED_METHODSto register actions.Changelog
CHANGELOG entry:null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Moderate risk because it changes how messenger actions are registered and renames a public hook method, which could break callers if any still reference the old handler name or types.
Overview
Refactors
InstitutionalSnapControllermessenger wiring to useregisterMethodActionHandlerswith an explicitMESSENGER_EXPOSED_METHODSlist, and renames the hook implementation fromdeferPublicationHooktopublishHook.Introduces an auto-generated
InstitutionalSnapController-method-action-types.tsand updates controller messenger typings/imports (includingTransactionControllerinit messenger) to consume these generated action types. Tooling is updated by bumping@metamask/messengerand adding@metamask/messenger-cli, with newmessenger-action-typescheck/generate steps integrated intolintandlint:fix.Reviewed by Cursor Bugbot for commit 492d266. Bugbot is set up for automated code reviews on this repo. Configure here.